-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ginkgo skip jhipster-online #508
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maximilianoPizarro The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @maximilianoPizarro. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
fe36bd6
to
e4c6160
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I'm just checking why the odo 3 check fails. I'm sure is not related with the current PR. I'll give it a bit of time till I re-run it if it fails again. I see the nightly run didn't exit for the same reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
I think the failure in CI is related to the mirror url, it might just be down currently
yeah I suspect so too. I guess let's give it some time |
/retest |
Bug reported failing check: devfile/api#1656 |
/retest |
@maximilianoPizarro Suggest a rebase, if the updated Red Hat Konflux check fails we can bypass it for this PR. |
Description of Changes
Only add --skip="stack: jhipster-online version: 2.23.0 starter: jhipster-online" from file tests/check_odov3.sh. Because fail in the step "with odo v3".
Example error in the last job:
https://github.com/devfile/registry/actions/runs/12200513685/job/34042081550
Summarizing 1 Failure:
[FAIL] test starter projects from devfile stacks [It] stack: jhipster-online version: 2.33.0 no_starter
/home/runner/work/registry/registry/tests/odov3/odo_test.go:192