Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populatate RepositoryBranch, ensure we pack it as expected #57

Closed
kzu opened this issue Dec 18, 2020 · 0 comments
Closed

Populatate RepositoryBranch, ensure we pack it as expected #57

kzu opened this issue Dec 18, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@kzu
Copy link
Member

kzu commented Dec 18, 2020

See https://docs.microsoft.com/en-us/dotnet/core/tools/csproj#repositorybranch

Ensure at a minimum that we're packing that property the same way as SDK Pack.
@kzu kzu added the enhancement New feature or request label Dec 18, 2020
kzu added a commit that referenced this issue May 10, 2021
@kzu
Populate RepositoryBranch automatically
d89fea3 
Support most popular CI systems.

Fixes #57
kzu added a commit that referenced this issue May 10, 2021
@kzu
Populate RepositoryBranch automatically
77d3c9d 
Support most popular CI systems.

Fixes #57
@kzu kzu mentioned this issue May 10, 2021
Merged
kzu added a commit that referenced this issue May 10, 2021
@kzu
Populate RepositoryBranch automatically
02c5694 
Support most popular CI systems.

Fixes #57
@kzu kzu closed this as completed in #93 May 10, 2021
kzu added a commit that referenced this issue May 10, 2021
@kzu
Populate RepositoryBranch automatically
08d5e03 
Support most popular CI systems.

Fixes #57
@kzu kzu changed the title Evaluate populating RepositoryBranch, ensure we pack it as expected Populatate RepositoryBranch, ensure we pack it as expected May 10, 2021
kzu added a commit to devlooped/GitInfo that referenced this issue Oct 29, 2024
@kzu
Set default GitBranch from CI env variables
19b99bf 
Virtually all CI systems provide environment variables containing the branch from the underlying source control.

This is already in use in:
https://github.com/dotnet/reproducible-builds/pull/
devlooped/oss#2
devlooped/nugetizer#57
devlooped/ThisAssembly#69

We should also bring in the same defaults here. Hopefully this will one day be part of SourceLink.
@kzu kzu mentioned this issue Oct 29, 2024
Merged
kzu added a commit to devlooped/GitInfo that referenced this issue Oct 29, 2024
@kzu
Set default GitBranch from CI env variables
1e0e2f4 
Virtually all CI systems provide environment variables containing the branch from the underlying source control.

This is already in use in:
https://github.com/dotnet/reproducible-builds/pull/
devlooped/oss#2
devlooped/nugetizer#57
devlooped/ThisAssembly#69

We should also bring in the same defaults here. Hopefully this will one day be part of SourceLink.
@devlooped devlooped locked and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kzu