Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement send_delete method in TFSHTTPClient in connection.py #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement send_delete method in TFSHTTPClient in connection.py #103

wants to merge 1 commit into from

Conversation

jmlesfrite
Copy link

No description provided.

allburov
allburov requested changes Jun 3, 2023
View reviewed changes
Copy link
Member

@allburov allburov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! A lot of changes have been made - did you use some formater for the code? I see there's confict with what we have in master branch also.

Could you rebase the change on thecurrent master branch?

@Boltyk
Copy link
Member

Boltyk commented Jun 6, 2023

@jmlesfrite thanks for contribution.
Can you extract formatting changes into the separate PR?

@allburov
Copy link
Member

allburov commented Jun 6, 2023

The project uses black tool as a format that runs https://pre-commit.com
https://github.com/devopshq/tfs/blob/master/.pre-commit-config.yaml#LL7C1-L7C1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allburov allburov allburov requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmlesfrite @Boltyk @allburov