Skip to content

Commit 7456def

Browse files
committed
Switched from prefixes to flags.
1 parent 327c643 commit 7456def

File tree

2 files changed

+18
-14
lines changed

2 files changed

+18
-14
lines changed

src/logger/logger.test.ts

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,8 @@ describe(Logger.name, () => {
8484

8585
expect(mockConsoleInfo).toHaveBeenCalledWith(
8686
JSON.stringify({
87-
message: '[USER] ' + message,
87+
message: message,
88+
verified: false,
8889
...mockEvent.payload.event_context,
8990
dev_oid: mockEvent.payload.event_context.dev_oid,
9091
})
@@ -102,7 +103,8 @@ describe(Logger.name, () => {
102103
});
103104
expect(mockConsoleInfo).toHaveBeenCalledWith(
104105
JSON.stringify({
105-
message: '[USER] ' + expectedMessage,
106+
message: expectedMessage,
107+
verified: false,
106108
...mockEvent.payload.event_context,
107109
dev_oid: mockEvent.payload.event_context.dev_oid,
108110
})
@@ -121,7 +123,8 @@ describe(Logger.name, () => {
121123
});
122124
expect(mockConsoleInfo).toHaveBeenCalledWith(
123125
JSON.stringify({
124-
message: `[USER] ${text} ${expectedDataMessage}`,
126+
message: `${text} ${expectedDataMessage}`,
127+
verified: false,
125128
...mockEvent.payload.event_context,
126129
dev_oid: mockEvent.payload.event_context.dev_oid,
127130
})
@@ -141,7 +144,8 @@ describe(Logger.name, () => {
141144
});
142145
expect(mockConsoleInfo).toHaveBeenCalledWith(
143146
JSON.stringify({
144-
message: `[USER] ${text1} ${expectedDataMessage} ${text2}`,
147+
message: `${text1} ${expectedDataMessage} ${text2}`,
148+
verified: false,
145149
...mockEvent.payload.event_context,
146150
dev_oid: mockEvent.payload.event_context.dev_oid,
147151
})
@@ -163,7 +167,7 @@ describe(Logger.name, () => {
163167

164168
logger.info(message, data);
165169

166-
expect(mockConsoleInfo).toHaveBeenCalledWith('[USER]', message, data);
170+
expect(mockConsoleInfo).toHaveBeenCalledWith(message, data);
167171
});
168172
});
169173

@@ -211,7 +215,7 @@ describe(Logger.name, () => {
211215
const callArgs = mockConsoleInfo.mock.calls[0][0];
212216
const logObject = JSON.parse(callArgs);
213217

214-
expect(logObject.message).toBe('[USER] ');
218+
expect(logObject.message).toBe('');
215219
expect(logObject.dev_oid).toBe(mockEvent.payload.event_context.dev_oid);
216220
expect(logObject.request_id).toBe(
217221
mockEvent.payload.event_context.request_id
@@ -226,7 +230,7 @@ describe(Logger.name, () => {
226230
const logObject = JSON.parse(callArgs);
227231

228232
// inspect shows 'null' and 'undefined' as strings
229-
expect(logObject.message).toBe('[USER] test null undefined');
233+
expect(logObject.message).toBe('test null undefined');
230234
expect(logObject.dev_oid).toBe(mockEvent.payload.event_context.dev_oid);
231235
});
232236

@@ -251,7 +255,7 @@ describe(Logger.name, () => {
251255
compact: false,
252256
depth: Infinity,
253257
});
254-
expect(logObject.message).toBe('[USER] ' + expectedMessage);
258+
expect(logObject.message).toBe(expectedMessage);
255259
expect(logObject.dev_oid).toBe(mockEvent.payload.event_context.dev_oid);
256260
expect(typeof logObject.callback_url).toBe('string');
257261
});

src/logger/private_logger.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ describe('Private Logger Security', () => {
5454
sdkLogger.info('SDK message');
5555

5656
expect(mockConsoleInfo).toHaveBeenCalledWith(
57-
expect.stringContaining('"message":"[SDK] SDK message"')
57+
expect.stringContaining('"message":"SDK message"')
5858
);
5959
});
6060

@@ -68,7 +68,7 @@ describe('Private Logger Security', () => {
6868
userLogger.info('User message');
6969

7070
expect(mockConsoleInfo).toHaveBeenCalledWith(
71-
expect.stringContaining('"message":"[USER] User message"')
71+
expect.stringContaining('"message":"User message"')
7272
);
7373
});
7474

@@ -109,10 +109,10 @@ describe('Private Logger Security', () => {
109109

110110
expect(mockConsoleInfo).toHaveBeenCalledTimes(2);
111111
expect(mockConsoleInfo).toHaveBeenNthCalledWith(1,
112-
expect.stringContaining('"message":"[SDK] SDK internal message"')
112+
expect.stringContaining('"message":"SDK internal message"')
113113
);
114114
expect(mockConsoleInfo).toHaveBeenNthCalledWith(2,
115-
expect.stringContaining('"message":"[USER] User application message"')
115+
expect.stringContaining('"message":"User application message"')
116116
);
117117
});
118118

@@ -134,8 +134,8 @@ describe('Private Logger Security', () => {
134134
expect(userCall).toContain('"dev_oid":"test-dev-oid"');
135135

136136
// But different prefixes
137-
expect(sdkCall).toContain('"[SDK] Warning from SDK"');
138-
expect(userCall).toContain('"[USER] Warning from user"');
137+
expect(sdkCall).toContain('"Warning from SDK"');
138+
expect(userCall).toContain('"Warning from user"');
139139
});
140140
});
141141

0 commit comments

Comments
 (0)