From 716144c22aa0ee65d8b436bed209065253ba27e1 Mon Sep 17 00:00:00 2001 From: geoff Date: Wed, 20 Oct 2021 11:28:35 +0930 Subject: [PATCH 1/8] added loadBalanceIP option to service.yaml --- charts/dex/templates/service.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/charts/dex/templates/service.yaml b/charts/dex/templates/service.yaml index 8114e8d5..1052be3e 100644 --- a/charts/dex/templates/service.yaml +++ b/charts/dex/templates/service.yaml @@ -13,6 +13,9 @@ spec: {{- with .Values.service.clusterIP }} clusterIP: {{ . }} {{- end }} + {{- with .Values.service.loadBalancerIP }} + loadBalancerIP: {{ . }} + {{- end }} ports: - name: http port: {{ .Values.service.ports.http.port }} From 523d184ded4e6f37f93f9702c4c6f507cf066b65 Mon Sep 17 00:00:00 2001 From: geoff Date: Wed, 20 Oct 2021 11:32:41 +0930 Subject: [PATCH 2/8] added default value for loadBalancerIP in values.yaml --- charts/dex/values.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/charts/dex/values.yaml b/charts/dex/values.yaml index 11cfb15a..000e7847 100644 --- a/charts/dex/values.yaml +++ b/charts/dex/values.yaml @@ -124,6 +124,9 @@ service: # -- Internal cluster service IP (when applicable) clusterIP: "" + + # -- External loadBalancer IP (when applicable) + loadBalancerIP: "" ports: http: From 6c6f421d58db4651af13a523cc9298c2a25611e3 Mon Sep 17 00:00:00 2001 From: geoff Date: Wed, 20 Oct 2021 11:35:22 +0930 Subject: [PATCH 3/8] added docs for loadBalancerIP --- charts/dex/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/charts/dex/README.md b/charts/dex/README.md index 34cd919d..11eac805 100644 --- a/charts/dex/README.md +++ b/charts/dex/README.md @@ -141,6 +141,7 @@ ingress: | service.annotations | object | `{}` | Annotations to be added to the service. | | service.type | string | `"ClusterIP"` | Kubernetes [service type](https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types). | | service.clusterIP | string | `""` | Internal cluster service IP (when applicable) | +| service.loadBalancerIP | string | `nil` | External cluster service IP (when applicable) | | service.ports.http.port | int | `5556` | HTTP service port | | service.ports.http.nodePort | int | `nil` | HTTP node port (when applicable) | | service.ports.https.port | int | `5554` | HTTPS service port | From 529bbcbe7047c319d16b9750b581e8ddfcb0ef59 Mon Sep 17 00:00:00 2001 From: geoff Date: Wed, 20 Oct 2021 11:37:02 +0930 Subject: [PATCH 4/8] change default for loadBalancerIP to null --- charts/dex/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/dex/values.yaml b/charts/dex/values.yaml index 000e7847..4f452da9 100644 --- a/charts/dex/values.yaml +++ b/charts/dex/values.yaml @@ -126,7 +126,7 @@ service: clusterIP: "" # -- External loadBalancer IP (when applicable) - loadBalancerIP: "" + loadBalancerIP: ports: http: From 6f19c92fa0a778f2cfa39a854c63ccbce493b19d Mon Sep 17 00:00:00 2001 From: geoff Date: Wed, 20 Oct 2021 11:40:39 +0930 Subject: [PATCH 5/8] Update Chart.yaml --- charts/dex/Chart.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/charts/dex/Chart.yaml b/charts/dex/Chart.yaml index 107c5877..3406fc51 100644 --- a/charts/dex/Chart.yaml +++ b/charts/dex/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v2 type: application name: dex -version: 0.6.3 +version: 0.6.4 appVersion: "2.30.0" kubeVersion: ">=1.14.0-0" description: OpenID Connect (OIDC) identity and OAuth 2.0 provider with pluggable connectors. @@ -23,6 +23,8 @@ annotations: artifacthub.io/changes: | - kind: added description: "`clusterIP` value to control the IP when using ClusterIP service type" + - kind: added + description: "`loadBalancerIP` configuration option added to helm chart" artifacthub.io/images: | - name: dex image: ghcr.io/dexidp/dex:v2.30.0 From 68513c97822ebcaafff8e83390561ae8d458302c Mon Sep 17 00:00:00 2001 From: geoff Date: Thu, 21 Oct 2021 17:48:55 +0930 Subject: [PATCH 6/8] Update charts/dex/Chart.yaml MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Márk Sági-Kazár --- charts/dex/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/dex/Chart.yaml b/charts/dex/Chart.yaml index 3406fc51..bcfae1cc 100644 --- a/charts/dex/Chart.yaml +++ b/charts/dex/Chart.yaml @@ -24,7 +24,7 @@ annotations: - kind: added description: "`clusterIP` value to control the IP when using ClusterIP service type" - kind: added - description: "`loadBalancerIP` configuration option added to helm chart" + description: "`loadBalancerIP` value to control the IP when using LoadBalancer service type" artifacthub.io/images: | - name: dex image: ghcr.io/dexidp/dex:v2.30.0 From c6e719e3020175717622fd50a5010f7d8e4970fa Mon Sep 17 00:00:00 2001 From: geoff Date: Thu, 21 Oct 2021 17:49:28 +0930 Subject: [PATCH 7/8] Update charts/dex/values.yaml MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Márk Sági-Kazár --- charts/dex/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/dex/values.yaml b/charts/dex/values.yaml index 4f452da9..353fd73a 100644 --- a/charts/dex/values.yaml +++ b/charts/dex/values.yaml @@ -125,7 +125,7 @@ service: # -- Internal cluster service IP (when applicable) clusterIP: "" - # -- External loadBalancer IP (when applicable) + # -- Load balancer IP (when applicable) loadBalancerIP: ports: From d5a30bcfea8ecc39620795a92125485e5ecdde1a Mon Sep 17 00:00:00 2001 From: geoff Date: Thu, 21 Oct 2021 17:54:13 +0930 Subject: [PATCH 8/8] Update Chart.yaml --- charts/dex/Chart.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/charts/dex/Chart.yaml b/charts/dex/Chart.yaml index bcfae1cc..8ccad8c1 100644 --- a/charts/dex/Chart.yaml +++ b/charts/dex/Chart.yaml @@ -21,8 +21,6 @@ maintainers: url: https://sagikazarmark.hu annotations: artifacthub.io/changes: | - - kind: added - description: "`clusterIP` value to control the IP when using ClusterIP service type" - kind: added description: "`loadBalancerIP` value to control the IP when using LoadBalancer service type" artifacthub.io/images: |