Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeql without build test #52

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Codeql without build test #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbb3009
Add CodeQL variant analysis scanning
dfarrell07 Aug 30, 2022
c6e31c8
Revert "Wrapped error is always nil"
dfarrell07 Aug 30, 2022
28c9019
Remove CodeQL build step
dfarrell07 Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/linting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,22 @@ jobs:
- name: Run packagedoc-lint
run: make packagedoc-lint

variant-analysis:
name: Variant Analysis
runs-on: ubuntu-latest
steps:
- name: Check out the repository
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b
- name: Initialize CodeQL
uses: github/codeql-action/init@2ca79b6fa8d3ec278944088b4aa5f46912db5d63
with:
languages: go
- name: Run CodeQL variant analysis
uses: github/codeql-action/analyze@2ca79b6fa8d3ec278944088b4aa5f46912db5d63
- name: Show CodeQL scan SARIF report
if: always()
run: cat ../results/go.sarif

vulnerability-scan:
name: Vulnerability Scanning
runs-on: ubuntu-latest
Expand Down
18 changes: 18 additions & 0 deletions .github/workflows/report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,24 @@ on:
permissions: {}

jobs:
variant-analysis:
name: Variant Analysis
runs-on: ubuntu-latest
permissions:
security-events: write
steps:
- name: Check out the repository
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b
- name: Initialize CodeQL
uses: github/codeql-action/init@2ca79b6fa8d3ec278944088b4aa5f46912db5d63
with:
languages: go
- name: Run CodeQL variant analysis
uses: github/codeql-action/analyze@2ca79b6fa8d3ec278944088b4aa5f46912db5d63
- name: Show CodeQL scan SARIF report
if: always()
run: cat ../results/go.sarif

vulnerability-scan:
name: Vulnerability Scanning
if: github.repository_owner == 'submariner-io'
Expand Down
2 changes: 1 addition & 1 deletion pkg/networkplugin-syncer/handlers/ovn/ovn_submariner_infrastructure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func (ovn *SyncHandler) ensureSubmarinerInfra() error {
}

if len(lbGroups) > 1 {
return errors.New("found more than one ovn load balancer group")
return errors.Wrap(err, "Found more than one ovn load balancer group")
}

ovnLogicalRouter := nbdb.LogicalRouter{
Expand Down