Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ees bulk upload guidance #64

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Add ees bulk upload guidance #64

merged 3 commits into from
Jul 30, 2024

Conversation

cjrace
Copy link
Contributor

@cjrace cjrace commented Jul 30, 2024

Overview of changes

Add new section on bulk uploads in EES

Why are these changes being made?

Recently released the new feature so wanted to add detailed instructions for it for users (and for our own future reference).

Detailed description of changes

New section under file uploads that explains the new bulk upload option

image

Updated all references to EES from "Explore Education Statistics" to "Explore education statistics" to match the service name.

Issue ticket number/s and link

No related issues.

Checklist before requesting a review

  • I have checked the contributing guidelines
  • I have checked for and linked any relevant issues that this may resolve
  • I have checked that these changes build locally
  • I understand that if merged into main, these changes will be publicly available

@cjrace cjrace marked this pull request as ready for review July 30, 2024 00:06
@jen-machin jen-machin self-requested a review July 30, 2024 07:12
@jen-machin
Copy link
Contributor

Happy with the explanation of the new process - would it help to also have a screenshot of an example of the dataset_names.csv file?

In terms of changing to "Explore education statistics" it's time for today's nitpicky comment! I'm sure you are thrilled. The style guide says that sentence case should be used for service names

image

I assume this means that anywhere that it occurs mid-sentence, it should be "explore education statistics"?

Happy to merge this as-is so you get it through for 1pm and then address these things separately if you wish.

jen-machin
jen-machin previously approved these changes Jul 30, 2024
Copy link
Contributor

@jen-machin jen-machin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment to address but nothing urgent that'd block the merge

@cjrace cjrace merged commit 74fd60e into main Jul 30, 2024
@cjrace cjrace deleted the add-ees-bulk-upload branch July 30, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants