Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for multiservice-discovery #100

Merged
merged 31 commits into from
Jan 24, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented Jan 23, 2024

Runs multiservice-discovery with local registry created from large02 testnet and execute tests on /prom/targets endpoint.
Add Bazel test:
//rs/ic-observability/multiservice-discovery:prom_targets_tests PASSED in 5.0s

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner January 23, 2024 12:19
@nikola-milosa
Copy link
Contributor

I think this should be synced with #93?

@pietrodimarco-dfinity
Copy link
Contributor Author

I think this should be synced with #93?
We don't have any metrics_proxy in testnet currently we can modify the test once it is merged

Copy link
Contributor

@NikolaMilosa NikolaMilosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pietrodimarco-dfinity pietrodimarco-dfinity added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit c6a0501 Jan 24, 2024
3 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the test-service-discovery-large02 branch January 24, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants