Fix test in service-discovery to be applied in mainnet registry #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pietrodimarco-dfinity
commented
Jan 29, 2024
•
pietrodimarco-dfinity
commented
- Add mainnet test using Bazel
* Add mainnet test using Cargo * Add mainnet test using Bazel * Add utility function to download and decompress archives
pietrodimarco-dfinity
changed the title
NikolaMilosa
approved these changes
Jan 30, 2024
sasa-tomic
reviewed
Jan 30, 2024
| let mut command = Command::new(BAZEL_BIN_PATH); | ||
|
|
||
| args.push(data_path.as_path().to_str().unwrap()); | ||
| let mut child = command.args(args).spawn().unwrap(); |
There was a problem hiding this comment.
So we're running bazel to fetch the archive, from within the test?
There may be a risk of a deadlock since there can only be one instance of bazel running at a time.
So this bazel target must depend on the BAZEL_DATA_PATH binary. Right?
A few lines of comments would generally be useful to understand what we're doing here.
| let handle = rt.spawn(async { fetch_targets().await }); | ||
| let targets = rt.block_on(handle).unwrap().unwrap(); | ||
| child.kill().expect("command couldn't be killed"); | ||
| assert_eq!(targets.len(), 7274); |
There was a problem hiding this comment.
This number will have to be updated from time to time? If yes, at least a comment would be useful:
- what is this?
- why are we doing it?
- how to update it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.