CI: Add a netlify configuration #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Quite silent here… @jwiegley @Dfinity-Bjoern, do you reliably get notified upon new PRs, or should I ping you explicitly? It would be good to get this or something like this in, to be able to link to the master version of the spec like we used to in the days of hydra. |
bogwar
approved these changes
May 13, 2022
✅ Deploy Preview for ic-interface-spec ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is really very useful use to have rendered previews of PRs easily available online, and also of the
masterbranch, and Netlify is the easiest way to to achieve that.This PR, which fixes #9, provides a simple netlify configuration using the existing nix builds. No further configuration or infrastructure is needed (e.g. no extra caches or such).
So all we need to get this live is
ic-interface-spec.netlify.appto begin with) and adds this repoI think the default configuration works just fine, and will create preview deployes for PRs.
They will look like this: https://ic-spec-pr-preview.netlify.app/