-
Notifications
You must be signed in to change notification settings - Fork 9
Add truncate to List. #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
rvanasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Review dismissed by automation script.
|
Is the trapping behaviour when out of bound desired? It could be more convenient for the code using this if truncating out of bound would do nothing. I mean in the same sense as a half-open interval [0,-1) is in some languages silently accepted as an empty interval and doesn't trap. Any opinions? |
|
We can generalize |
I don't have a strong opinion either way about this but am slightly leaning towards no-op instead of trapping. |
Same. I think it makes surrounding code easier because it saves some
We could, but |
No description provided.