Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text roundtrip tests [ACT-110 related] #614

Merged
merged 15 commits into from
Aug 13, 2019
Merged

Text roundtrip tests [ACT-110 related] #614

merged 15 commits into from
Aug 13, 2019

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Aug 12, 2019

Checks mostly the UTF-8 encoder/decoder.

@ggreif ggreif marked this pull request as ready for review August 12, 2019 14:36
@ggreif ggreif requested a review from kritzcreek August 12, 2019 14:36
Copy link
Contributor

@kritzcreek kritzcreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ggreif
Copy link
Contributor Author

ggreif commented Aug 12, 2019

We found a backend bug: "compile_lit_pat: (CharLit 166628)" when compiling '\u{28ae4}'!

@ggreif
Copy link
Contributor Author

ggreif commented Aug 12, 2019

Blocked on #615.

@ggreif ggreif changed the title Text roundtrip tests Text roundtrip tests [ACT-110 related] Aug 13, 2019
@ggreif ggreif merged commit ab3f397 into master Aug 13, 2019
dfinity-bot added a commit that referenced this pull request Feb 21, 2024
## Changelog for motoko-base:
Branch: next-moc
Commits: [dfinity/motoko-base@b772c9e4...520ccf5d](dfinity/motoko-base@b772c9e...520ccf5)

* [`0f14b175`](dfinity/motoko-base@0f14b17) Unused Declaration Cleanup ([dfinity/motoko-base⁠#614](https://togithub.com/dfinity/motoko-base/issues/614))
mergify bot pushed a commit that referenced this pull request Feb 21, 2024
## Changelog for motoko-base:
Branch: next-moc
Commits: [dfinity/motoko-base@b772c9e4...520ccf5d](dfinity/motoko-base@b772c9e...520ccf5)

* [`0f14b175`](dfinity/motoko-base@0f14b17) Unused Declaration Cleanup ([dfinity/motoko-base⁠#614](https://togithub.com/dfinity/motoko-base/issues/614))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants