From bc8afa42b850e49cf037211b586eabcdb9920886 Mon Sep 17 00:00:00 2001
From: Cosku Cinkilic <cosku.cinkilic@dfinity.org>
Date: Wed, 2 Oct 2024 10:33:50 +0200
Subject: [PATCH 1/5] use increaseDissolvDelay for sns neurons

---
 frontend/src/lib/api/sns-governance.api.ts    | 12 +++++-----
 .../IncreaseSnsDissolveDelayModal.svelte      | 10 ++++----
 .../src/lib/services/sns-neurons.services.ts  | 14 +++++------
 .../tests/lib/api/sns-governance.api.spec.ts  | 18 +++++++-------
 .../IncreaseSnsDissolveDelayModal.spec.ts     |  9 ++++---
 .../lib/services/sns-neurons.services.spec.ts | 24 +++++++++----------
 6 files changed, 42 insertions(+), 45 deletions(-)

diff --git a/frontend/src/lib/api/sns-governance.api.ts b/frontend/src/lib/api/sns-governance.api.ts
index de66c856de6..9c8d40c5552 100644
--- a/frontend/src/lib/api/sns-governance.api.ts
+++ b/frontend/src/lib/api/sns-governance.api.ts
@@ -247,27 +247,27 @@ export const stopDissolving = async ({
   logWithTimestamp(`Stop dissolving sns neuron complete.`);
 };
 
-export const setDissolveDelay = async ({
+export const increaseDissolveDelay = async ({
   identity,
   rootCanisterId,
   neuronId,
-  dissolveTimestampSeconds,
+  additionalDissolveDelaySeconds,
 }: {
   identity: Identity;
   rootCanisterId: Principal;
   neuronId: SnsNeuronId;
-  dissolveTimestampSeconds: number;
+  additionalDissolveDelaySeconds: number;
 }): Promise<void> => {
   logWithTimestamp(`Increase sns dissolve delay call...`);
 
-  const { setDissolveTimestamp } = await wrapper({
+  const { increaseDissolveDelay } = await wrapper({
     identity,
     rootCanisterId: rootCanisterId.toText(),
     certified: true,
   });
-  await setDissolveTimestamp({
+  await increaseDissolveDelay({
     neuronId,
-    dissolveTimestampSeconds: BigInt(dissolveTimestampSeconds),
+    additionalDissolveDelaySeconds: additionalDissolveDelaySeconds,
   });
 
   logWithTimestamp(`Increase sns dissolve delay complete.`);
diff --git a/frontend/src/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.svelte b/frontend/src/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.svelte
index 7fc1f2d062b..f68cf22bb33 100644
--- a/frontend/src/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.svelte
+++ b/frontend/src/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.svelte
@@ -1,7 +1,7 @@
 <script lang="ts">
   import ConfirmSnsDissolveDelay from "$lib/components/sns-neurons/ConfirmSnsDissolveDelay.svelte";
   import SetSnsDissolveDelay from "$lib/components/sns-neurons/SetSnsDissolveDelay.svelte";
-  import { updateDelay } from "$lib/services/sns-neurons.services";
+  import { increaseDissolveDelay } from "$lib/services/sns-neurons.services";
   import { startBusy, stopBusy } from "$lib/stores/busy.store";
   import { i18n } from "$lib/stores/i18n";
   import { toastsError } from "$lib/stores/toasts.store";
@@ -38,12 +38,12 @@
   let currentStep: WizardStep | undefined;
   let modal: WizardModal;
 
-  let delayInSeconds = Number(
+  let existingDissolveDelay = Number(
     getSnsLockedTimeInSeconds(neuron) ??
       getSnsDissolvingTimeInSeconds(neuron) ??
       0n
   );
-
+  let delayInSeconds = existingDissolveDelay;
   const dispatcher = createEventDispatcher();
   const goNext = () => {
     modal.next();
@@ -55,10 +55,10 @@
         initiator: "dissolve-sns-action",
       });
 
-      const { success } = await updateDelay({
+      const { success } = await increaseDissolveDelay({
         rootCanisterId,
         neuron,
-        dissolveDelaySeconds: delayInSeconds,
+        additionalDissolveDelaySeconds: delayInSeconds - existingDissolveDelay,
       });
 
       await reloadNeuron();
diff --git a/frontend/src/lib/services/sns-neurons.services.ts b/frontend/src/lib/services/sns-neurons.services.ts
index d869f382537..7e2d55a93e1 100644
--- a/frontend/src/lib/services/sns-neurons.services.ts
+++ b/frontend/src/lib/services/sns-neurons.services.ts
@@ -5,10 +5,10 @@ import {
   disburse as disburseApi,
   disburseMaturity as disburseMaturityApi,
   getSnsNeuron as getSnsNeuronApi,
+  increaseDissolveDelay as increaseDissolveDelayApi,
   querySnsNeuron,
   querySnsNeurons,
   removeNeuronPermissions,
-  setDissolveDelay,
   setFollowees,
   splitNeuron as splitNeuronApi,
   stakeMaturity as stakeMaturityApi,
@@ -31,7 +31,6 @@ import {
 } from "$lib/stores/sns-neurons.store";
 import { toastsError, toastsSuccess } from "$lib/stores/toasts.store";
 import type { Account } from "$lib/types/account";
-import { nowInSeconds } from "$lib/utils/date.utils";
 import { notForceCallStrategy } from "$lib/utils/env.utils";
 import { toToastError } from "$lib/utils/error.utils";
 import { ledgerErrorToToastError } from "$lib/utils/sns-ledger.utils";
@@ -424,23 +423,22 @@ export const stopDissolving = async ({
   }
 };
 
-export const updateDelay = async ({
+export const increaseDissolveDelay = async ({
   rootCanisterId,
   neuron,
-  dissolveDelaySeconds,
+  additionalDissolveDelaySeconds,
 }: {
   rootCanisterId: Principal;
   neuron: SnsNeuron;
-  dissolveDelaySeconds: number;
+  additionalDissolveDelaySeconds: number;
 }): Promise<{ success: boolean }> => {
   try {
     const identity = await getSnsNeuronIdentity();
-
-    await setDissolveDelay({
+    await increaseDissolveDelayApi({
       rootCanisterId,
       identity,
       neuronId: fromDefinedNullable(neuron.id),
-      dissolveTimestampSeconds: nowInSeconds() + dissolveDelaySeconds,
+      additionalDissolveDelaySeconds: additionalDissolveDelaySeconds,
     });
 
     return { success: true };
diff --git a/frontend/src/tests/lib/api/sns-governance.api.spec.ts b/frontend/src/tests/lib/api/sns-governance.api.spec.ts
index d007d529ac8..4d9ca73307a 100644
--- a/frontend/src/tests/lib/api/sns-governance.api.spec.ts
+++ b/frontend/src/tests/lib/api/sns-governance.api.spec.ts
@@ -6,6 +6,7 @@ import {
   disburseMaturity,
   getNeuronBalance,
   getSnsNeuron,
+  increaseDissolveDelay,
   queryProposal,
   queryProposals,
   querySnsNeuron,
@@ -13,7 +14,6 @@ import {
   refreshNeuron,
   registerVote,
   removeNeuronPermissions,
-  setDissolveDelay,
   setFollowees,
   splitNeuron,
   stakeMaturity,
@@ -73,7 +73,7 @@ describe("sns-api", () => {
   const splitNeuronSpy = vi.fn().mockResolvedValue(undefined);
   const startDissolvingSpy = vi.fn().mockResolvedValue(undefined);
   const stopDissolvingSpy = vi.fn().mockResolvedValue(undefined);
-  const setDissolveDelaySpy = vi.fn().mockResolvedValue(undefined);
+  const increaseDissolveDelaySpy = vi.fn().mockResolvedValue(undefined);
   const getNeuronBalanceSpy = vi.fn().mockResolvedValue(undefined);
   const refreshNeuronSpy = vi.fn().mockResolvedValue(undefined);
   const claimNeuronSpy = vi.fn().mockResolvedValue(undefined);
@@ -125,7 +125,7 @@ describe("sns-api", () => {
         splitNeuron: splitNeuronSpy,
         startDissolving: startDissolvingSpy,
         stopDissolving: stopDissolvingSpy,
-        setDissolveTimestamp: setDissolveDelaySpy,
+        increaseDissolveDelay: increaseDissolveDelaySpy,
         getNeuronBalance: getNeuronBalanceSpy,
         refreshNeuron: refreshNeuronSpy,
         claimNeuron: claimNeuronSpy,
@@ -243,18 +243,18 @@ describe("sns-api", () => {
     expect(stopDissolvingSpy).toBeCalled();
   });
 
-  it("should setDissolveDelay", async () => {
-    const dissolveTimestampSeconds = 123;
+  it("should increaseDissolveDelay", async () => {
+    const additionalDissolveDelaySeconds = 123;
     const neuronId = { id: arrayOfNumberToUint8Array([1, 2, 3]) };
-    await setDissolveDelay({
+    await increaseDissolveDelay({
       identity: mockIdentity,
       rootCanisterId: rootCanisterIdMock,
       neuronId,
-      dissolveTimestampSeconds,
+      additionalDissolveDelaySeconds,
     });
 
-    expect(setDissolveDelaySpy).toBeCalledWith({
-      dissolveTimestampSeconds: BigInt(dissolveTimestampSeconds),
+    expect(increaseDissolveDelaySpy).toBeCalledWith({
+      additionalDissolveDelaySeconds: additionalDissolveDelaySeconds,
       neuronId,
     });
   });
diff --git a/frontend/src/tests/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.spec.ts b/frontend/src/tests/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.spec.ts
index b16e9db402e..301e5358575 100644
--- a/frontend/src/tests/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.spec.ts
+++ b/frontend/src/tests/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.spec.ts
@@ -166,17 +166,16 @@ describe("IncreaseSnsDissolveDelayModal", () => {
     );
 
     expect(confirmButton).toBeDefined();
-    expect(snsGovernanceApi.setDissolveDelay).toBeCalledTimes(0);
+    expect(snsGovernanceApi.increaseDissolveDelay).toBeCalledTimes(0);
 
     confirmButton && (await fireEvent.click(confirmButton));
 
     await waitFor(() =>
-      expect(snsGovernanceApi.setDissolveDelay).toBeCalledTimes(1)
+      expect(snsGovernanceApi.increaseDissolveDelay).toBeCalledTimes(1)
     );
-    expect(snsGovernanceApi.setDissolveDelay).toBeCalledWith(
+    expect(snsGovernanceApi.increaseDissolveDelay).toBeCalledWith(
       expect.objectContaining({
-        dissolveTimestampSeconds:
-          daysToSeconds(increaseDelayDays) + nowInSeconds,
+        additionalDissolveDelaySeconds: daysToSeconds(increaseDelayDays),
       })
     );
   });
diff --git a/frontend/src/tests/lib/services/sns-neurons.services.spec.ts b/frontend/src/tests/lib/services/sns-neurons.services.spec.ts
index 4843d590e9d..894cc2774e2 100644
--- a/frontend/src/tests/lib/services/sns-neurons.services.spec.ts
+++ b/frontend/src/tests/lib/services/sns-neurons.services.spec.ts
@@ -7,12 +7,12 @@ import * as services from "$lib/services/sns-neurons.services";
 import {
   disburse,
   disburseMaturity,
+  increaseDissolveDelay,
   increaseStakeNeuron,
   stakeMaturity,
   startDissolving,
   stopDissolving,
   toggleAutoStakeMaturity,
-  updateDelay,
 } from "$lib/services/sns-neurons.services";
 import { snsNeuronsStore } from "$lib/stores/sns-neurons.store";
 import { toastsError } from "$lib/stores/toasts.store";
@@ -415,37 +415,37 @@ describe("sns-neurons-services", () => {
     });
   });
 
-  describe("updateDelay ", () => {
-    let spyOnSetDissolveDelay;
+  describe("increaseDissolveDelay ", () => {
+    let spyOnIncreaseDissolveDelay;
     const nowInSeconds = 1689063315;
     const now = nowInSeconds * 1000;
 
     beforeEach(() => {
-      spyOnSetDissolveDelay = vi
-        .spyOn(governanceApi, "setDissolveDelay")
+      spyOnIncreaseDissolveDelay = vi
+        .spyOn(governanceApi, "increaseDissolveDelay")
         .mockImplementation(() => Promise.resolve());
       vi.useFakeTimers().setSystemTime(now);
-      spyOnSetDissolveDelay.mockClear();
+      spyOnIncreaseDissolveDelay.mockClear();
     });
 
-    it("should call sns api setDissolveDelay with dissolve timestamp", async () => {
+    it("should call sns api increaseDissolveDelay with additional dissolve delay in seconds", async () => {
       const neuronId = fromDefinedNullable(mockSnsNeuron.id);
       const identity = mockIdentity;
       const rootCanisterId = mockPrincipal;
-      const dissolveDelaySeconds = 123;
-      const { success } = await updateDelay({
+      const additionalDissolveDelaySeconds = 123;
+      const { success } = await increaseDissolveDelay({
         rootCanisterId,
-        dissolveDelaySeconds,
+        additionalDissolveDelaySeconds,
         neuron: mockSnsNeuron,
       });
 
       expect(success).toBeTruthy();
 
-      expect(spyOnSetDissolveDelay).toBeCalledWith({
+      expect(spyOnIncreaseDissolveDelay).toBeCalledWith({
         neuronId,
         identity,
         rootCanisterId,
-        dissolveTimestampSeconds: nowInSeconds + dissolveDelaySeconds,
+        additionalDissolveDelaySeconds,
       });
     });
   });

From c83204ee42a9b593992bcec54f418ed76b1b44a0 Mon Sep 17 00:00:00 2001
From: Cosku Cinkilic <cosku.cinkilic@dfinity.org>
Date: Wed, 2 Oct 2024 20:16:02 +0200
Subject: [PATCH 2/5] fix tests

---
 .../IncreaseSnsDissolveDelayModal.svelte      | 10 +++---
 .../src/lib/services/sns-neurons.services.ts  | 21 +++++++++----
 .../lib/services/sns-neurons.services.spec.ts | 31 ++++++++++++-------
 3 files changed, 40 insertions(+), 22 deletions(-)

diff --git a/frontend/src/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.svelte b/frontend/src/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.svelte
index f68cf22bb33..8a5cd02b3b6 100644
--- a/frontend/src/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.svelte
+++ b/frontend/src/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.svelte
@@ -1,7 +1,7 @@
 <script lang="ts">
   import ConfirmSnsDissolveDelay from "$lib/components/sns-neurons/ConfirmSnsDissolveDelay.svelte";
   import SetSnsDissolveDelay from "$lib/components/sns-neurons/SetSnsDissolveDelay.svelte";
-  import { increaseDissolveDelay } from "$lib/services/sns-neurons.services";
+  import { updateDelay } from "$lib/services/sns-neurons.services";
   import { startBusy, stopBusy } from "$lib/stores/busy.store";
   import { i18n } from "$lib/stores/i18n";
   import { toastsError } from "$lib/stores/toasts.store";
@@ -38,12 +38,12 @@
   let currentStep: WizardStep | undefined;
   let modal: WizardModal;
 
-  let existingDissolveDelay = Number(
+  let delayInSeconds = Number(
     getSnsLockedTimeInSeconds(neuron) ??
       getSnsDissolvingTimeInSeconds(neuron) ??
       0n
   );
-  let delayInSeconds = existingDissolveDelay;
+
   const dispatcher = createEventDispatcher();
   const goNext = () => {
     modal.next();
@@ -55,10 +55,10 @@
         initiator: "dissolve-sns-action",
       });
 
-      const { success } = await increaseDissolveDelay({
+      const { success } = await updateDelay({
         rootCanisterId,
         neuron,
-        additionalDissolveDelaySeconds: delayInSeconds - existingDissolveDelay,
+        dissolveDelay: delayInSeconds,
       });
 
       await reloadNeuron();
diff --git a/frontend/src/lib/services/sns-neurons.services.ts b/frontend/src/lib/services/sns-neurons.services.ts
index 7e2d55a93e1..30cbae4822e 100644
--- a/frontend/src/lib/services/sns-neurons.services.ts
+++ b/frontend/src/lib/services/sns-neurons.services.ts
@@ -5,7 +5,7 @@ import {
   disburse as disburseApi,
   disburseMaturity as disburseMaturityApi,
   getSnsNeuron as getSnsNeuronApi,
-  increaseDissolveDelay as increaseDissolveDelayApi,
+  increaseDissolveDelay,
   querySnsNeuron,
   querySnsNeurons,
   removeNeuronPermissions,
@@ -36,6 +36,8 @@ import { toToastError } from "$lib/utils/error.utils";
 import { ledgerErrorToToastError } from "$lib/utils/sns-ledger.utils";
 import {
   followeesByFunction,
+  getSnsDissolvingTimeInSeconds,
+  getSnsLockedTimeInSeconds,
   getSnsNeuronByHexId,
   hasAutoStakeMaturityOn,
   isEnoughAmountToSplit,
@@ -423,22 +425,29 @@ export const stopDissolving = async ({
   }
 };
 
-export const increaseDissolveDelay = async ({
+export const updateDelay = async ({
   rootCanisterId,
   neuron,
-  additionalDissolveDelaySeconds,
+  dissolveDelay,
 }: {
   rootCanisterId: Principal;
   neuron: SnsNeuron;
-  additionalDissolveDelaySeconds: number;
+  dissolveDelay: number;
 }): Promise<{ success: boolean }> => {
   try {
     const identity = await getSnsNeuronIdentity();
-    await increaseDissolveDelayApi({
+
+    const existingDissolveDelay = Number(
+      getSnsLockedTimeInSeconds(neuron) ??
+        getSnsDissolvingTimeInSeconds(neuron) ??
+        0n
+    );
+
+    await increaseDissolveDelay({
       rootCanisterId,
       identity,
       neuronId: fromDefinedNullable(neuron.id),
-      additionalDissolveDelaySeconds: additionalDissolveDelaySeconds,
+      additionalDissolveDelaySeconds: dissolveDelay - existingDissolveDelay,
     });
 
     return { success: true };
diff --git a/frontend/src/tests/lib/services/sns-neurons.services.spec.ts b/frontend/src/tests/lib/services/sns-neurons.services.spec.ts
index 894cc2774e2..a4e1edcaa50 100644
--- a/frontend/src/tests/lib/services/sns-neurons.services.spec.ts
+++ b/frontend/src/tests/lib/services/sns-neurons.services.spec.ts
@@ -7,13 +7,14 @@ import * as services from "$lib/services/sns-neurons.services";
 import {
   disburse,
   disburseMaturity,
-  increaseDissolveDelay,
   increaseStakeNeuron,
   stakeMaturity,
   startDissolving,
   stopDissolving,
   toggleAutoStakeMaturity,
+  updateDelay,
 } from "$lib/services/sns-neurons.services";
+
 import { snsNeuronsStore } from "$lib/stores/sns-neurons.store";
 import { toastsError } from "$lib/stores/toasts.store";
 import { tokensStore } from "$lib/stores/tokens.store";
@@ -32,12 +33,14 @@ import {
 import { mockSnsMainAccount } from "$tests/mocks/sns-accounts.mock";
 import {
   buildMockSnsNeuronsStoreSubscribe,
+  createMockSnsNeuron,
   mockSnsNeuron,
 } from "$tests/mocks/sns-neurons.mock";
 import { mockSnsToken, mockTokenStore } from "$tests/mocks/sns-projects.mock";
 import { resetMockedConstants } from "$tests/utils/mockable-constants.test-utils";
 import { resetSnsProjects, setSnsProjects } from "$tests/utils/sns.test-utils";
 import { decodeIcrcAccount } from "@dfinity/ledger-icrc";
+import { NeuronState } from "@dfinity/nns";
 import { Principal } from "@dfinity/principal";
 import {
   SnsNeuronPermissionType,
@@ -415,12 +418,13 @@ describe("sns-neurons-services", () => {
     });
   });
 
-  describe("increaseDissolveDelay ", () => {
+  describe("updateDelay ", () => {
     let spyOnIncreaseDissolveDelay;
-    const nowInSeconds = 1689063315;
+    let nowInSecondsSpy;
+    const nowInSeconds = 10;
     const now = nowInSeconds * 1000;
-
     beforeEach(() => {
+      nowInSecondsSpy?.mockRestore();
       spyOnIncreaseDissolveDelay = vi
         .spyOn(governanceApi, "increaseDissolveDelay")
         .mockImplementation(() => Promise.resolve());
@@ -428,15 +432,20 @@ describe("sns-neurons-services", () => {
       spyOnIncreaseDissolveDelay.mockClear();
     });
 
-    it("should call sns api increaseDissolveDelay with additional dissolve delay in seconds", async () => {
-      const neuronId = fromDefinedNullable(mockSnsNeuron.id);
+    it("should call sns api setDissolveDelay with additional dissolve delay in seconds", async () => {
+      const mockNeuronWithWhenDissolvedTS = createMockSnsNeuron({
+        state: NeuronState.Dissolving,
+        whenDissolvedTimestampSeconds: BigInt(100),
+      });
+
+      const neuronId = fromDefinedNullable(mockNeuronWithWhenDissolvedTS.id);
       const identity = mockIdentity;
       const rootCanisterId = mockPrincipal;
-      const additionalDissolveDelaySeconds = 123;
-      const { success } = await increaseDissolveDelay({
+      const delayInSeconds = 150;
+      const { success } = await updateDelay({
         rootCanisterId,
-        additionalDissolveDelaySeconds,
-        neuron: mockSnsNeuron,
+        dissolveDelay: delayInSeconds,
+        neuron: mockNeuronWithWhenDissolvedTS,
       });
 
       expect(success).toBeTruthy();
@@ -445,7 +454,7 @@ describe("sns-neurons-services", () => {
         neuronId,
         identity,
         rootCanisterId,
-        additionalDissolveDelaySeconds,
+        additionalDissolveDelaySeconds: 60,
       });
     });
   });

From 2629afd1d028eb93f4b4377a3b2efcf8bc37b695 Mon Sep 17 00:00:00 2001
From: Cosku Cinkilic <cosku.cinkilic@dfinity.org>
Date: Wed, 2 Oct 2024 20:19:30 +0200
Subject: [PATCH 3/5] Delete extra spy

---
 frontend/src/tests/lib/services/sns-neurons.services.spec.ts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/frontend/src/tests/lib/services/sns-neurons.services.spec.ts b/frontend/src/tests/lib/services/sns-neurons.services.spec.ts
index a4e1edcaa50..6423a86cd1f 100644
--- a/frontend/src/tests/lib/services/sns-neurons.services.spec.ts
+++ b/frontend/src/tests/lib/services/sns-neurons.services.spec.ts
@@ -420,11 +420,9 @@ describe("sns-neurons-services", () => {
 
   describe("updateDelay ", () => {
     let spyOnIncreaseDissolveDelay;
-    let nowInSecondsSpy;
     const nowInSeconds = 10;
     const now = nowInSeconds * 1000;
     beforeEach(() => {
-      nowInSecondsSpy?.mockRestore();
       spyOnIncreaseDissolveDelay = vi
         .spyOn(governanceApi, "increaseDissolveDelay")
         .mockImplementation(() => Promise.resolve());

From cdd9d05cad62b5d5375948d8dfadae3c20f4fb7a Mon Sep 17 00:00:00 2001
From: Cosku Cinkilic <cosku.cinkilic@dfinity.org>
Date: Wed, 2 Oct 2024 20:20:54 +0200
Subject: [PATCH 4/5] revert to old naming

---
 .../sns/neurons/IncreaseSnsDissolveDelayModal.svelte       | 2 +-
 frontend/src/lib/services/sns-neurons.services.ts          | 7 ++++---
 .../src/tests/lib/services/sns-neurons.services.spec.ts    | 2 +-
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/frontend/src/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.svelte b/frontend/src/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.svelte
index 8a5cd02b3b6..7fc1f2d062b 100644
--- a/frontend/src/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.svelte
+++ b/frontend/src/lib/modals/sns/neurons/IncreaseSnsDissolveDelayModal.svelte
@@ -58,7 +58,7 @@
       const { success } = await updateDelay({
         rootCanisterId,
         neuron,
-        dissolveDelay: delayInSeconds,
+        dissolveDelaySeconds: delayInSeconds,
       });
 
       await reloadNeuron();
diff --git a/frontend/src/lib/services/sns-neurons.services.ts b/frontend/src/lib/services/sns-neurons.services.ts
index 30cbae4822e..b70004e5447 100644
--- a/frontend/src/lib/services/sns-neurons.services.ts
+++ b/frontend/src/lib/services/sns-neurons.services.ts
@@ -428,11 +428,11 @@ export const stopDissolving = async ({
 export const updateDelay = async ({
   rootCanisterId,
   neuron,
-  dissolveDelay,
+  dissolveDelaySeconds,
 }: {
   rootCanisterId: Principal;
   neuron: SnsNeuron;
-  dissolveDelay: number;
+  dissolveDelaySeconds: number;
 }): Promise<{ success: boolean }> => {
   try {
     const identity = await getSnsNeuronIdentity();
@@ -447,7 +447,8 @@ export const updateDelay = async ({
       rootCanisterId,
       identity,
       neuronId: fromDefinedNullable(neuron.id),
-      additionalDissolveDelaySeconds: dissolveDelay - existingDissolveDelay,
+      additionalDissolveDelaySeconds:
+        dissolveDelaySeconds - existingDissolveDelay,
     });
 
     return { success: true };
diff --git a/frontend/src/tests/lib/services/sns-neurons.services.spec.ts b/frontend/src/tests/lib/services/sns-neurons.services.spec.ts
index 6423a86cd1f..dce6630b1ab 100644
--- a/frontend/src/tests/lib/services/sns-neurons.services.spec.ts
+++ b/frontend/src/tests/lib/services/sns-neurons.services.spec.ts
@@ -442,7 +442,7 @@ describe("sns-neurons-services", () => {
       const delayInSeconds = 150;
       const { success } = await updateDelay({
         rootCanisterId,
-        dissolveDelay: delayInSeconds,
+        dissolveDelaySeconds: delayInSeconds,
         neuron: mockNeuronWithWhenDissolvedTS,
       });
 

From 95401aa860c51c497cb53ea72e2ddc36fdd78a57 Mon Sep 17 00:00:00 2001
From: Cosku Cinkilic <cosku.cinkilic@dfinity.org>
Date: Thu, 3 Oct 2024 10:39:15 +0200
Subject: [PATCH 5/5] Remove blankline

---
 frontend/src/tests/lib/services/sns-neurons.services.spec.ts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/frontend/src/tests/lib/services/sns-neurons.services.spec.ts b/frontend/src/tests/lib/services/sns-neurons.services.spec.ts
index dce6630b1ab..ba168aa5741 100644
--- a/frontend/src/tests/lib/services/sns-neurons.services.spec.ts
+++ b/frontend/src/tests/lib/services/sns-neurons.services.spec.ts
@@ -14,7 +14,6 @@ import {
   toggleAutoStakeMaturity,
   updateDelay,
 } from "$lib/services/sns-neurons.services";
-
 import { snsNeuronsStore } from "$lib/stores/sns-neurons.store";
 import { toastsError } from "$lib/stores/toasts.store";
 import { tokensStore } from "$lib/stores/tokens.store";