Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing "HeaderName losing first row of data" bug (#417) #427

Closed
wants to merge 1 commit into from

Conversation

mjsqu
Copy link

@mjsqu mjsqu commented Aug 24, 2018

Added $HeaderName to conditional statement to start looking for data at the first row when Headers are supplied. Fixes #417

Added $HeaderName to conditional statement to start looking for data at the first row when Headers are supplied.
@mjsqu mjsqu changed the title Fixing "HeaderName losing first row of data" bug Fixing "HeaderName losing first row of data" bug (#417) Aug 24, 2018
@mjsqu
Copy link
Author

mjsqu commented Aug 24, 2018

Possibly caused by 39a68e7#diff-f50d26003c0baf98f417a44fc1cac92b
Line number 361 in ImportExcel.psm1 was changed to remove -not ($NoHeader -or $HeaderName)), but replacement logic only included a conditional for $NoHeader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using parameter -HeaderName to supply custom headers incorrectly skips first row (data) of sheet
2 participants