Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions ignored when composer.json / $externalComposerFilename not found #18

Open
becw opened this issue Mar 23, 2015 · 1 comment
Open

Comments

@becw
Copy link

becw commented Mar 23, 2015

See the use of $this->error in https://github.com/dflydev/dflydev-embedded-composer/blob/master/src/Dflydev/EmbeddedComposer/Core/EmbeddedComposerBuilder.php#L137

For some projects (ie, Sculpin), the composer.json is optional, so these exceptions should not be thrown; for other projects, they may be meaningful/required.

@simensen
Copy link
Member

I think the solution would be to have builder have some sort of strict mode enabling thing.

    ->shouldExceptionOnMissingExternalComposerFilename()

... or somesuch. In this case it would actually throw an exception if the file is missing. Otherwise, we could just continue to silently consume these exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants