Add Content-Length checking before decoding #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to explicit 204 (NO CONTENT), there are occasions where the server may send a 0 length response and those won't decode very well either.
|
Thanks |
dmitshur
reviewed
Nov 27, 2020
| // If the status code of response is 204(no content), decoding is skipped. | ||
| // Any error creating the request, sending it, or decoding the response is | ||
| // returned. | ||
| // If the status code of response is 204(no content) or the Content-Lenght is 0, |
There was a problem hiding this comment.
In case it's helpful to you, please note there's a typo in "Content-Lenght". It should be "Content-Length".
|
any plans to release this change @dghubble ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a pattern with REST APIs at work where they return a 201 with a Location header for the new resource and an empty response body. Sling would attempt to decode the empty response body and return an EOF error.