ci(e2e): update e2e tests to work with latest cypress utils #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismay
commented
Jun 8, 2021
ismay
commented
Jun 8, 2021
ismay
commented
Jun 8, 2021
ismay
commented
Jun 8, 2021
ismay
force-pushed
the
update-cypress-workflows
branch
from
ff7a352 to
f785433
Compare
ismay
commented
Jun 8, 2021
HendrikThePendric
requested changes
Jun 9, 2021
There was a problem hiding this comment.
Looks good, I think we should change one minor thing, see #14 (comment)
ismay
force-pushed
the
update-cypress-workflows
branch
from
f785433 to
d057edf
Compare
HendrikThePendric
approved these changes
Jun 9, 2021
varl
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports the changes made to the e2e workflow for the scheduler (here). Can be merged once the stable version of the cypress utils is out (or before, but then we should clarify it's meant to be used with the alpha version of the cypress utils).