check bounds in readAPICFrame

Fixes #80
dhowden · Nov 19, 2020 · a922134 · a922134
1 parent 4b595ed
commit a922134
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/id3v2frames.go b/id3v2frames.go
@@ -608,8 +608,15 @@ func readPICFrame(b []byte) (*Picture, error) {
 // Description     <text string according to encoding> $00 (00)
 // Picture data    <binary data>
 func readAPICFrame(b []byte) (*Picture, error) {
+	if len(b) == 0 {
+		return nil, errors.New("error decoding APIC: invalid encoding")
+	}
 	enc := b[0]
 	mimeDataSplit := bytes.SplitN(b[1:], singleZero, 2)
+	if len(mimeDataSplit) != 2 {
+		return nil, errors.New("error decoding APIC: invalid encoding")
+	}
+
 	mimeType := string(mimeDataSplit[0])
 
 	b = mimeDataSplit[1]