Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix id3v2 sum error #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yinhylin
Copy link

No description provided.

Copy link
Owner

@dhowden dhowden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for the change.

I think that this is checking for ID3v1 (not v2) hence why it's not considered in SumID3v2 (it's done in SumID3v1).

Is there something else going on here that means you need to implement it there?

@ghost
Copy link

ghost commented Sep 13, 2023

@dhowden An mp3 file can have both ID3v1 and ID3v2 tags. This seems to be common on Linux as I've gotten many files that have both. Currently, for files that have both, Sum includes the IDv1 tags in the Sum when it shouldn't.

Also, I believe ID3v2.4 allows the frames to be at the end or beginning of a file, but the library always assumes it's at the beginning.

@yinhylin Thanks for doing this. This is one of the things that I needed. The last consideration is XING headers (like the LAME header) and whether that should be included in the Sum or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants