feature: support auto-hide comments when page navigated #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When navigate with the comments open, it auto-hide the comment.
code formatted prettier.
dideler
reviewed
Mar 13, 2018
|
@dideler Thanks for approval. This is a confirmation for a moment. I think this new feature is not backward compatible (UI doesn't change but UX changes). I'm aware that it is v4.0.0. |
|
Hey @1natsu172, I was away for another holiday (this time in Wales) - thanks for your patience. Would you like to release this feature? Since you built it, you can have the pleasure of shipping it. |
|
Welcome back @dideler . Yes, I'll release this feature. Maybe I can take time tomorrow or the day after tomorrow. (Since I don't have time today, I only reply). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #19
I implemented the feature discussed in the issue.
#21 was submitting from the fork repository, so I resubmitted this PR.
Please review when have time. 🙏