print disjuncts in Gentzen sequent separately #3164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kroening
commented
Oct 14, 2018
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- My contribution is formatted in line with CODING_STANDARD.md.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
tautschnig
requested changes
Oct 14, 2018
Collaborator
tautschnig
left a comment
tautschnig
left a comment
There was a problem hiding this comment.
- Why?
- Missing tests.
- This piece of code will require further work once the
functionmember is gone frominstructiontas noted below.
| for(const auto &disjunct : disjuncts) | ||
| { | ||
| std::string string_value = | ||
| from_expr(ns, s_it->source.pc->function, disjunct); |
Collaborator
There was a problem hiding this comment.
Aren't we removing the function member?
Collaborator
Author
|
kroening
force-pushed
the
show_vcc_disjunction
branch
from
871298a to
185c912
Compare
Rationale: This avoids a long "{1}" line and matches the usual definition of
the Gentzen sequent.
kroening
force-pushed
the
show_vcc_disjunction
branch
from
185c912 to
09a7989
Compare
tautschnig
approved these changes
Oct 14, 2018
allredj
reviewed
Oct 14, 2018
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 871298a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87887369
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
allredj
reviewed
Oct 14, 2018
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 09a7989).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87893119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.