-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/tidy up three way merge #7929
Refactor/tidy up three way merge #7929
Conversation
798d2e7
to
2092f2b
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7929 +/- ##
===========================================
- Coverage 79.11% 78.85% -0.27%
===========================================
Files 1701 1701
Lines 196271 196265 -6
===========================================
- Hits 155280 154758 -522
- Misses 40991 41507 +516
☔ View full report in Codecov by Sentry. |
Anyone know why CodeCov is failing?
|
I believe this is a throttling issue. Just happens from time to time, a re-run typically resolves this. |
src/analyses/variable-sensitivity/variable_sensitivity_dependence_graph.cpp
Outdated
Show resolved
Hide resolved
2092f2b
to
254250f
Compare
Given that the operation is taking the diff between function start and function end and applying it to a base, you would think that it should only have three domains. It previously had four and then copied the entire calling domain over the "this" domain, which was not otherwise used. This patch simplifies this and removes that oddity.
254250f
to
515f263
Compare
One test fails which is a 0.27% drop in project coverage. I think this is an artefact of measurement because I am removing lines. The patch coverage is 100% so I am going to merge it. |
This tidies up a few things around VSD's three way merge. It should have no externally visible effect.