Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/tidy up three way merge #7929

Merged

Conversation

martin-cs
Copy link
Collaborator

This tidies up a few things around VSD's three way merge. It should have no externally visible effect.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3535b61) 79.11% compared to head (515f263) 78.85%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7929      +/-   ##
===========================================
- Coverage    79.11%   78.85%   -0.27%     
===========================================
  Files         1701     1701              
  Lines       196271   196265       -6     
===========================================
- Hits        155280   154758     -522     
- Misses       40991    41507     +516     
Files Coverage Δ
...nsitivity/three_way_merge_abstract_interpreter.cpp 93.18% <100.00%> (+0.07%) ⬆️
...sitivity/variable_sensitivity_dependence_graph.cpp 85.05% <ø> (ø)
...ensitivity/variable_sensitivity_dependence_graph.h 78.68% <ø> (ø)
...riable-sensitivity/variable_sensitivity_domain.cpp 90.10% <100.00%> (+0.16%) ⬆️
...variable-sensitivity/variable_sensitivity_domain.h 100.00% <ø> (ø)

... and 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-cs
Copy link
Collaborator Author

Anyone know why CodeCov is failing?

[2023-09-28T16:22:09.663Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
[2023-09-28T16:22:09.664Z] ['verbose'] The error stack is: Error: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
    at main (/snapshot/repo/dist/src/index.js)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

@tautschnig
Copy link
Collaborator

Anyone know why CodeCov is failing?

[2023-09-28T16:22:09.663Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
[2023-09-28T16:22:09.664Z] ['verbose'] The error stack is: Error: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
    at main (/snapshot/repo/dist/src/index.js)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

I believe this is a throttling issue. Just happens from time to time, a re-run typically resolves this.

@tautschnig tautschnig assigned martin-cs and unassigned tautschnig Sep 29, 2023
@martin-cs martin-cs force-pushed the refactor/tidy-up-three-way-merge branch from 2092f2b to 254250f Compare September 29, 2023 15:30
@peterschrammel peterschrammel removed their assignment Oct 17, 2023
Given that the operation is taking the diff between function start and
function end and applying it to a base, you would think that it should only
have three domains.  It previously had four and then copied the entire
calling domain over the "this" domain, which was not otherwise used.
This patch simplifies this and removes that oddity.
@martin-cs martin-cs force-pushed the refactor/tidy-up-three-way-merge branch from 254250f to 515f263 Compare October 18, 2023 22:23
@martin-cs
Copy link
Collaborator Author

One test fails which is a 0.27% drop in project coverage. I think this is an artefact of measurement because I am removing lines. The patch coverage is 100% so I am going to merge it.

@martin-cs martin-cs merged commit a6c5175 into diffblue:develop Oct 19, 2023
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants