Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use zero_extend_exprt in SMT2 front-end #8493

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

kroening
Copy link
Member

@kroening kroening commented Nov 4, 2024

This replaces the use of a typecast expression by zero_extend_exprt when parsing an SMT-LIB2 zero_extend expression.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This replaces the use of a typecast expression by zero_extend_exprt when
parsing an SMT-LIB2 zero_extend expression.
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.88%. Comparing base (8fcd9b1) to head (6d8eb16).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8493   +/-   ##
========================================
  Coverage    78.88%   78.88%           
========================================
  Files         1727     1727           
  Lines       198398   198410   +12     
  Branches     18509    18528   +19     
========================================
+ Hits        156504   156518   +14     
+ Misses       41894    41892    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -693,9 +693,9 @@ exprt smt2_parsert::function_application()
else if(id=="zero_extend")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it: please change to id == ID_zero_extend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants