Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: sort icons to group variants #476

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Fix: sort icons to group variants #476

merged 3 commits into from
Feb 14, 2024

Conversation

tomasciccola
Copy link
Contributor

@tomasciccola tomasciccola commented Feb 13, 2024 •
edited
Loading

given that this bug wasn't caught by tests, I use this PR to add a couple more tests of icons

gmaclennan
gmaclennan requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nit-picks on the code, which don't actually need any change, since they do work fine as-is.

The test though needs a check to make sure that your new assertions are actually being called.

src/config-import.js Show resolved Hide resolved
src/config-import.js Outdated Show resolved Hide resolved
tests/config-import.js Outdated Show resolved Hide resolved
@EvanHahn EvanHahn added the mvp Requirement for MVP label Feb 13, 2024
@tomasciccola tomasciccola merged commit 38104e1 into main Feb 14, 2024
7 checks passed
@tomasciccola tomasciccola deleted the fix/sortIcons branch February 14, 2024 16:53
@tomasciccola tomasciccola self-assigned this Feb 14, 2024
@optic-release-automation optic-release-automation bot mentioned this pull request Mar 14, 2024
Merged
This was referenced Apr 11, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Apr 30, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request May 9, 2024
Merged
This was referenced Jun 20, 2024
Merged
Merged
Merged
This was referenced Jul 25, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Aug 13, 2024
Merged
This was referenced Aug 21, 2024
Merged
Merged
This was referenced Aug 29, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Sep 11, 2024
Closed
This was referenced Sep 16, 2024
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmaclennan gmaclennan gmaclennan requested changes

@EvanHahn EvanHahn Awaiting requested review from EvanHahn

Assignees

@tomasciccola tomasciccola

Labels
mvp Requirement for MVP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomasciccola @gmaclennan @EvanHahn