Use old JAXB artifacts #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure the JAXB facilities (generated code and marshallers) can be living alongside any jakarta.xml.bind namespaced JAXB in newer Java applications. This ensures that we are using JAXB API and runtime artifacts which have other Maven coordinates than the newer Jakarta-branded artifacts, which started out with the old javax.xml.bind package, but in later versions changed this to jakarta.xml.bind. If dependees use newer Jakarta JAXB with the proper package, this will break the use of this library if it is depending on the Jakarta-artifacts with the javax.xml.bind package. It's a mess.
Resolving the old javax.xml.bind JAXB 2 stuff using the ServiceLoader facilities. This enables depending projects to be able to bypass our custom stuff to load JAXB if they for some reason needs to do so (e.g. if already running in an environment using javax.xml.bind JAXB with some other implementation they want to use instead).
runeflobakk
force-pushed
the
old-is-older
branch
from
97f5412 to
d7f572b
Compare
Slf4J-Simple used in tests
This module is a candidate for extracting to a standalone lib
runeflobakk
force-pushed
the
old-is-older
branch
from
0679aac to
ff7c105
Compare
Move config of japicmp to profile in order to complement base config in super-pom. Remove rule for required Maven version, because this is specified in the super-POM.
runeflobakk
commented
Mar 14, 2023
Comment on lines
+135
to
+140
| <dependency> | ||
| <groupId>no.digipost</groupId> | ||
| <artifactId>jul-to-slf4j-junit-extension</artifactId> | ||
| <version>1.0</version> | ||
| <scope>test</scope> | ||
| </dependency> |
Member
Author
There was a problem hiding this comment.
runeflobakk
force-pushed
the
old-is-older
branch
from
ce3c540 to
4d3bb4d
Compare
runeflobakk
commented
Mar 14, 2023
Comment on lines
45
to
51
| <dependency> | ||
| <groupId>no.digipost</groupId> | ||
| <artifactId>jaxb-resolver-com.sun.xml.bind-bom</artifactId> | ||
| <version>0.1-RC2</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> |
Member
Author
There was a problem hiding this comment.
simenstoa
approved these changes
Mar 14, 2023
Contributor
simenstoa
left a comment
simenstoa
left a comment
There was a problem hiding this comment.
Nice! Tar gjerne en live oppsummering av dette på kontoret også 😄
Member
Author
|
Absolutt! Her er det mye gøy! |
runeflobakk
force-pushed
the
old-is-older
branch
from
4d3bb4d to
35f4bd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure the JAXB facilities (generated code and marshallers) can be living alongside any jakarta.xml.bind namespaced JAXB in newer Java applications.
This (hopefully) ensures that we are using JAXB API and runtime artifacts which have other Maven coordinates than the newer Jakarta-branded artifacts, which started out with still containing old
javax.xml.bindpackage, but in later versions changed this tojakarta.xml.bind. If dependees use newer Jakarta JAXB with the proper package, this will break the use of this library if it is depending on the Jakarta-artifacts with the javax.xml.bind package.It's a mess.
https://stackoverflow.com/a/72151763