Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make file globs compatible with rules_docker's py3_image() #9

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

lazcamus
Copy link
Contributor

There are 2 incompatibilities with the python install that pyenv creates:

So pass flags to glob() to exclude these sticking points, and you can now build
a container (or tar) with rules_pyenv built python.

There are 2 incompatibilities with the python install that pyenv creates:
* empty directories - bazel's sandbox mode + rules_pkg doesn't work with
  them: bazelbuild/rules_pkg#135
* spaces in filenames - bazelbuild/bazel#374

So pass flags to glob() to exclude these sticking points, and you can now build
a container (or tar) with rules_pyenv built python.
@ddlees
Copy link
Collaborator

ddlees commented Mar 11, 2022

@lazcamus This looks great. Would you be willing to also update the examples to show how to build a container with pyenv built python? If not I'll try to pull some time together and do it myself when I can get to it.

@lazcamus
Copy link
Contributor Author

lazcamus commented Mar 20, 2022 via email

@ddlees
Copy link
Collaborator

ddlees commented Mar 22, 2022

Such is life 😄 . I'll try to cobble something together sometime soon unless you beat me to it. In the meantime, I'll merge so you and others can at least pull from the branch to try it out.

@ddlees ddlees merged commit e07673c into digital-plumbers-union:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants