-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary caches and release branches #1740
Comments
I'm not sure I understand what you mean, could you elaborate? We can declare a binary cache via the flake, that is then pulled in by the users, so this could be set differently per version: Line 178 in 62376a9
|
That is exactly what I meant 👍 |
Am I reading cachix pins right in that it could actually preserve store paths from the latest of each release branch, and by that also not having to ever change binary cache to support each release? |
Yes, this would work. But right now it seems not to be what is causing our issues with all the recent missing builds |
+1 - I'm having all sorts of issues getting Cachix to work. Depending on the project it will try to build anywhere from 30-130 packages from source using ghc. |
@CSchank can you verify that your |
Builds should be fixed now (this time likely for real :D)! The problem was that the cachix action doesn't support nix flakes yet, so the nix flakes output wasn't pushed to cachix at all. I've fixed this by manually pushing it there. |
So, @mpscholten should I try to update an old project to the Nix Flakes-based IHP and see if caching works? |
Yep, you can give it a try. As the |
@mpscholten it still seems to want to build IHP for me :( (Note this isn't in GitHub Actions, this is just on my macOS computer)
Edit: Let's move this discussion to #1745 as it seems to only happen to me when I'm upgrading an old project to use Flakes. |
* Added documentation about the new version branches Fixes #1740 * Update CONTRIBUTING.md Co-authored-by: Lars Lillo Ulvestad <lars.lillo@gmail.com> * Update CONTRIBUTING.md Co-authored-by: Lars Lillo Ulvestad <lars.lillo@gmail.com> --------- Co-authored-by: Lars Lillo Ulvestad <lars.lillo@gmail.com>
I would like to highlight the suggestion from @Eisfunke here #1705 (comment) about release branches and fork it into a separate issue :)
I think this will be vital for the future of smooth IHP deployments on Shipnix and other platforms
A repeating issue is non-matching binary caches, and that it's difficult to debug when a binary cache is actually working for the current version, and that the server suddenly takes one hour to deploy, if the server is even powerful enough to pull it off.
If we could ensure that the latest version always is covered by the binary cache, I think deployment on all platforms would be really great.
Then if building IHP takes a long time, the solution would probably often be just to run
nix flake update
and try again.Nice to haves:
Could we even could support an individual binary cache for each release branch at least maybe one or two versions down?
And, maybe even better, could even the binary be declared under the hood from the IHP source? I'm guessing it probably isn't as simple as it sounds, but would be great if it was xD
The text was updated successfully, but these errors were encountered: