Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow completion of aliases in zsh #482

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Allow completion of aliases in zsh #482

merged 1 commit into from
Jul 3, 2019

Conversation

eddiezane
Copy link
Contributor

This PR allows the completion of aliases of commands in zsh.

For example:

doctl k8s <tab> will now properly complete as if the command was typed as doctl kubernetes <tab>

Ref:
helm/helm#5680
helm/helm@48f0e31

@eddiezane eddiezane self-assigned this Jul 3, 2019
@eddiezane eddiezane requested a review from kamaln7 July 3, 2019 00:11
@kamaln7
Copy link
Contributor

kamaln7 commented Jul 3, 2019

Confirmed working, these autocomplete as expected:

doctl kubernetes <tab>
doctl k8s <tab>

But doctl k8<tab> doesn't autocomplete to k8s. I guess that's because k8s isn't exported as a command, only as an alias?

@eddiezane eddiezane merged commit 54e97aa into master Jul 3, 2019
@eddiezane eddiezane deleted the ez/allow-completion-of-aliases branch July 3, 2019 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamaln7 kamaln7 kamaln7 approved these changes

Assignees

@eddiezane eddiezane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddiezane @kamaln7