Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .exe suffix to Windows binary filenames #510

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Add .exe suffix to Windows binary filenames #510

merged 1 commit into from
Jul 22, 2019

Conversation

bentranter
Copy link
Member

@bentranter bentranter commented Jul 22, 2019 •
edited
Loading

Back when we were still using xgo for cross-compilation, all Windows binaries has the .exe suffix. Turns out that was something xgo was doing for us, so this PR adds that behaviour to our current manual cross compilation script.

Fixes #509

@bentranter bentranter requested a review from hilary July 22, 2019 20:09
hilary
hilary approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@hilary hilary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hilary hilary merged commit d708db0 into digitalocean:master Jul 22, 2019
@bentranter bentranter deleted the bug-windows-binary-filenames-missing-exe branch July 22, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hilary hilary hilary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing .exe
2 participants
@bentranter @hilary