Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a natural request representation #18

Merged
merged 13 commits into from
Dec 16, 2019
Merged

Use a natural request representation #18

merged 13 commits into from
Dec 16, 2019

Conversation

dcereijodo
Copy link
Contributor

@dcereijodo dcereijodo commented Dec 13, 2019 •
edited
Loading

Closes #17

  • Re-think whether is a good idea to use a full JSON level to represent the method or if it would be better a simple attribute
  • Wrap response body
  • Remove domain from request parameters as it will be constant
  • Create tests for added support for headers
  • Create tests for added custom exception
  • Scaladoc
  • Update README.md

@dcereijodo dcereijodo marked this pull request as ready for review December 16, 2019 14:06
@dcereijodo dcereijodo merged commit 45a5e10 into master Dec 16, 2019
@dcereijodo dcereijodo deleted the feat/natural-request-repr branch December 16, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Natural request representation
1 participant
@dcereijodo