Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Infinite loop when requesting negative number of ARKs #40

Closed
bondjimbond opened this issue Jun 6, 2024 · 0 comments · Fixed by #42
Closed

BUG: Infinite loop when requesting negative number of ARKs #40

bondjimbond opened this issue Jun 6, 2024 · 0 comments · Fixed by #42
Assignees

Comments

@bondjimbond
Copy link

Testing out how POST requests work, user input a negative number (-1) into the "How many ARKs would you like to mint?" field (https://github.com/digitalutsc/arks-service/blob/main/admin/admin.php#L1051).

This results in an infinite loop here: https://github.com/digitalutsc/arks-service/blob/main/admin/admin.php#L1065-L1067

Result is that the server creates new ARKs infinitely, with 34,000 minted by the time the error was reported to me.

It's a weird choice to input a negative number (user wanted to see what would happen), but would be good to prevent that kind of input from getting through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants