Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elm-markup files not parsed succesfully #20

Closed
antoine-atmire opened this issue Nov 13, 2019 · 4 comments
Closed

Elm-markup files not parsed succesfully #20

antoine-atmire opened this issue Nov 13, 2019 · 4 comments

Comments

@antoine-atmire
Copy link

I have a basic content/elm-markup.emu file which works with 1.0.39 (npm) and 1.0.0 (elm) but which cannot be rendered with elm-pages 1.0.40 (npm) and 1.0.1 (elm)

The page shows up like this

/elm-markup
I couldn't parse the frontmatter in this page. I ran into this error with your JSON decoder:
Failure
@dillonkearns
Copy link
Owner

I released a fix for this: https://github.com/dillonkearns/elm-pages/blob/master/CHANGELOG-NPM.md#1041---2019-11-14

Could you try it out and let me know if it's looking good now? Thank you!

@antoine-atmire
Copy link
Author

/elm-markup is a blank and unresponsive page now, while all other pages render properly.

@dillonkearns
Copy link
Owner

Hello @antoine-atmire! I'm not sure if you're still using elm-markup with elm-pages. If you are, could you take a look and let me know how things work with the latest version using elm-markup?

I've removed the coupling to elm-markup, so the way to do it now is to store the elm-markup metadata in a field in your frontmatter (instead of it being raw elm-markup directly in the frontmatter of the file).

@dillonkearns
Copy link
Owner

I believe this is fixed, so I'll close this for now. Please let me know if you run into any other problems. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants