Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay copying of elm files to /gen folder until cli app is done #23

Merged
merged 3 commits into from
Jan 4, 2020

Commits on Nov 14, 2019

  1. Delay copying of elm files to /gen folder until cli app is done

    Before this change webpack started compiling before the cli version
    if the app was compiled in doCliStuff.
    
    Not sure how but this was causing webpack to send the cli version
    of the app to the browser when main.js was requested. This caused
    the app to not render anything (because it was a worker app) and
    not show any errors.
    
    The change just waits until the cli finished compiling to only
    then move the .elm files to the /gen folder, triggering webpack
    to recompile using the correct (ui version) of the app.
    danmarcab committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    362e5ff View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2020

  1. Configuration menu
    Copy the full SHA
    dd785ea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a28856d View commit details
    Browse the repository at this point in the history