Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downloadAsFileUpload to file proxies #2782

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

freya022
Copy link
Contributor

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

Makes re-uploading attachments easier.

* @return {@link FileUpload} from this attachment.
*/
@Nonnull
public FileUpload downloadAsFileUpload(@Nonnull String name, int width, int height)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add an overload that just uses the known attachment filename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have the file name as AttachmentProxy is used by MessageEmbed.Thumbnail and MessageEmbed.ImageInfo and they don't have that info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants