From 8002448e3610793b15d3cb8cce012e1429d04736 Mon Sep 17 00:00:00 2001 From: Alec Woods <ahnolds@gmail.com> Date: Sat, 19 Dec 2020 10:36:52 -0500 Subject: [PATCH] Apply suggestions from code review --- src/rest/RequestHandler.js | 14 +++++--------- src/util/Constants.js | 2 +- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/rest/RequestHandler.js b/src/rest/RequestHandler.js index 7e1d6898bc48..07416452ce6b 100644 --- a/src/rest/RequestHandler.js +++ b/src/rest/RequestHandler.js @@ -73,14 +73,10 @@ class RequestHandler { globalDelayFor(ms) { return new Promise(resolve => { - this.manager.client.setTimeout( - manager => { - manager.globalDelay = null; - resolve(); - }, - ms, - this.manager, - ); + this.manager.client.setTimeout(() => { + this.manager.globalDelay = null; + resolve(); + }, ms); }); } @@ -189,7 +185,7 @@ class RequestHandler { /* * This is a sublimit (e.g. 2 channel name changes/10 minutes) since the headers don't indicate a * route-wide rate limit. Don't update remaining or reset to avoid rate limit the whole endpoint, - * just set a reset time on the request itself to avodi retrying too soon. + * just set a reset time on the request itself to avoid retrying too soon. */ res.sublimit = retryAfter; } diff --git a/src/util/Constants.js b/src/util/Constants.js index 9d8a4a32b52c..3c23931a0a84 100644 --- a/src/util/Constants.js +++ b/src/util/Constants.js @@ -36,7 +36,7 @@ const browser = (exports.browser = typeof window !== 'undefined'); * @property {number} [restRequestTimeout=15000] Time to wait before cancelling a REST request, in milliseconds * @property {number} [restSweepInterval=60] How frequently to delete inactive request buckets, in seconds * (or 0 for never) - * @property {number} [restGlobalRateLimit=0] How many messages to allow sending per second (0 for unlimited, 50 for + * @property {number} [restGlobalRateLimit=0] How many requests to allow sending per second (0 for unlimited, 50 for * the standard global limit used by Discord) * @property {number} [retryLimit=1] How many times to retry on 5XX errors (Infinity for indefinite amount of retries) * @property {PresenceData} [presence] Presence data to use upon login