Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

VoiceReceiver constructor should probably be marked @internal #190

Open
iliazeus opened this issue Aug 25, 2021 · 0 comments
Open

VoiceReceiver constructor should probably be marked @internal #190

iliazeus opened this issue Aug 25, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@iliazeus
Copy link

Please describe the problem you are having in as much detail as possible:

Upgrading from 0.5.x versions, changing createVoiceRecevier(connection) to new VoiceReceiver(connection) seemed to be the logical choice. However, the only VoiceReceiver that works with a given connection seems to be the VoiceConnection.receiver.

I suggest marking the VoiceReceiver constructor as @internal, to avoid confusion.

Include a reproducible code sample here, if possible:

const r1 = new VoiceReceiver(voiceConnection);
r1.speaking.on("start", () => console.log("never gets called"));

const r2 = voiceConnection.receiver;
r2.speaking.on("start", () => console.log("but this one does"));

Further details:

  • @discordjs/voice version: 0.6.0
  • Priority this issue should have – please be realistic and elaborate if possible: same as all documentation issues, probably

Relevant client options:

  • partials: none
  • gateway intents: none
  • other: none
@iliazeus iliazeus added the bug Something isn't working label Aug 25, 2021
@amishshah amishshah self-assigned this Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants