This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
chore: update examples for v13 #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
=======================================
Coverage 73.84% 73.84%
=======================================
Files 21 21
Lines 906 906
Branches 221 227 +6
=======================================
Hits 669 669
Misses 235 235
Partials 2 2
Continue to review full report at Codecov.
|
iim-ayush
suggested changes
Aug 10, 2021
| const app = await client.application?.fetch(); | ||
| const devGuild = await client.guilds.fetch(deployment_guild_id).catch(() => null); | ||
| if (app && devGuild) { | ||
| await devGuild.commands.set([ |
There was a problem hiding this comment.
It would be great to have some check if the commands are already present in the guild before setting commands again and again at every start of bot.
DaStormer
reviewed
Aug 11, 2021
Closed
|
@Fyko could you remove the unnecessary intent mentioned above and also move command deployment to its own script that can be run separately? |
Co-authored-by: DaStormer <40336269+DaStormer@users.noreply.github.com>
|
Why it's not getting merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR updates examples for Discord.js v13. Additionally, it fixes a documentation error.
Closes #170.
Status and versioning classification: