From 7995e87b6c00166553b2fe62f4098624492180a0 Mon Sep 17 00:00:00 2001 From: David Taylor Date: Mon, 2 Oct 2023 15:10:21 +0100 Subject: [PATCH] DEV: Remove deprecated `showFooter` calls (#248) This is now handled in Discourse core via the `hide-application-footer` helper in the user-topics-list template --- .../discourse/controllers/user-activity-reactions.js | 10 ---------- .../discourse/routes/user-activity-reactions.js | 1 - 2 files changed, 11 deletions(-) diff --git a/assets/javascripts/discourse/controllers/user-activity-reactions.js b/assets/javascripts/discourse/controllers/user-activity-reactions.js index 0bd55dd..4abd314 100644 --- a/assets/javascripts/discourse/controllers/user-activity-reactions.js +++ b/assets/javascripts/discourse/controllers/user-activity-reactions.js @@ -13,11 +13,6 @@ export default class UserActivityReactions extends Controller { @tracked beforeLikeId = null; @tracked beforeReactionUserId = null; - constructor() { - super(...arguments); - this.set("application.showFooter", !this.canLoadMore); - } - #getLastIdFrom(array) { return array.length ? array[array.length - 1].get("id") : null; } @@ -48,11 +43,6 @@ export default class UserActivityReactions extends Controller { @action loadMore() { - if (!this.canLoadMore || this.loading || !this.reactionsUrl) { - this.set("application.showFooter", !this.canLoadMore); - return; - } - this.loading = true; const reactionUsers = this.model; diff --git a/assets/javascripts/discourse/routes/user-activity-reactions.js b/assets/javascripts/discourse/routes/user-activity-reactions.js index af48f10..445e102 100644 --- a/assets/javascripts/discourse/routes/user-activity-reactions.js +++ b/assets/javascripts/discourse/routes/user-activity-reactions.js @@ -17,6 +17,5 @@ export default class UserActivityReactions extends DiscourseRoute { reactionsUrl: "reactions", username: this.modelFor("user").get("username"), }); - this.controllerFor("application").set("showFooter", loadedAll); } }