Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrepareResp format does not match DAP draft-07 #2466

Closed
divergentdave opened this issue Jan 9, 2024 · 0 comments · Fixed by #2469
Closed

PrepareResp format does not match DAP draft-07 #2466

divergentdave opened this issue Jan 9, 2024 · 0 comments · Fixed by #2469

Comments

@divergentdave
Copy link
Contributor

The serialization and deserialization routines for PrepareResp fail to include a 4-byte length prefix before the payload, if the state is equal to continue.

Given that Janus 0.6 is already deployed, but not yet interoperating with any other aggregators, I think it would make sense to not fix this on our draft-07 branch, and instead fix it when we implement draft-09. We expect to do interoperation testing against Daphne on the draft-09 version of the protocol.
This was referenced Jan 9, 2024
Closed
Merged
tgeoghegan added a commit that referenced this issue Jan 10, 2024
@tgeoghegan
Fix PrepareRespResult wire encoding
c06ffa8 
Include the 4 byte length prefix when encoding ping-pong messages into a
`PrepareRespResult`.

Closes #2466
@tgeoghegan tgeoghegan mentioned this issue Jan 10, 2024
Merged
tgeoghegan added a commit that referenced this issue Jan 10, 2024
@tgeoghegan
Fix PrepareInit, PrepareContinue, PrepareRespResult, wire encoding (…
1ce0333 
…#2469)

Include the 4 byte length prefix when encoding ping-pong messages into a
`PrepareInit`, `PrepareContinue`, or `PrepareRespResult`.

Closes #2466
inahga pushed a commit that referenced this issue Jan 18, 2024
@tgeoghegan @inahga
Fix PrepareInit, PrepareContinue, PrepareRespResult, wire encoding (…
9ae06ef 
…#2469)

Include the 4 byte length prefix when encoding ping-pong messages into a
`PrepareInit`, `PrepareContinue`, or `PrepareRespResult`.

Closes #2466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix PrepareRespResult wire encoding divviup/janus
1 participant
@divergentdave