From bc8e8e56fe0773acb6b1e715f81537a51576e566 Mon Sep 17 00:00:00 2001 From: santiavenda2 Date: Wed, 20 Sep 2017 11:12:25 -0300 Subject: [PATCH 1/4] Fix factory boy dependency --- requirements-development.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/requirements-development.txt b/requirements-development.txt index 8a06afd6..960fd5db 100644 --- a/requirements-development.txt +++ b/requirements-development.txt @@ -5,6 +5,7 @@ isort mock pytest>=2.9.0,<3.0 pytest-django +factory-boy==2.8.1 pytest-factoryboy recommonmark Sphinx From b772a15db3976ffc3e29ecaba0b8c916a40bf269 Mon Sep 17 00:00:00 2001 From: santiavenda2 Date: Wed, 20 Sep 2017 11:51:07 -0300 Subject: [PATCH 2/4] fix factory-boy version in setup.py and requirements-development.txt --- requirements-development.txt | 2 +- setup.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/requirements-development.txt b/requirements-development.txt index 960fd5db..7bd14ea1 100644 --- a/requirements-development.txt +++ b/requirements-development.txt @@ -5,7 +5,7 @@ isort mock pytest>=2.9.0,<3.0 pytest-django -factory-boy==2.8.1 +factory-boy<2.9.0 pytest-factoryboy recommonmark Sphinx diff --git a/setup.py b/setup.py index e91ec5e5..704ccd06 100755 --- a/setup.py +++ b/setup.py @@ -105,6 +105,7 @@ def get_package_data(package): setup_requires=pytest_runner + sphinx + wheel, tests_require=[ 'pytest-factoryboy', + 'factory-boy<2.9.0' 'pytest-django', 'pytest>=2.8,<3', 'django-polymorphic', From 08ce59039cc22228666d70284c69bcd84d6b13bb Mon Sep 17 00:00:00 2001 From: santiavenda2 Date: Wed, 20 Sep 2017 14:28:09 -0300 Subject: [PATCH 3/4] Fix setup.py factory boy dependency --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 704ccd06..40865c43 100755 --- a/setup.py +++ b/setup.py @@ -105,7 +105,7 @@ def get_package_data(package): setup_requires=pytest_runner + sphinx + wheel, tests_require=[ 'pytest-factoryboy', - 'factory-boy<2.9.0' + 'factory-boy<2.9.0', 'pytest-django', 'pytest>=2.8,<3', 'django-polymorphic', From 24ef800bf55396bcf418ed326966f2eef9ac48d1 Mon Sep 17 00:00:00 2001 From: Matt Layman Date: Wed, 11 Oct 2017 11:22:59 -0400 Subject: [PATCH 4/4] Add an explanation about factory_boy version pinning Include a link to the GitHub issue so a future dev will know when the dependency can be unpinned. --- requirements-development.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/requirements-development.txt b/requirements-development.txt index 7bd14ea1..52a7c54e 100644 --- a/requirements-development.txt +++ b/requirements-development.txt @@ -5,6 +5,7 @@ isort mock pytest>=2.9.0,<3.0 pytest-django +# factory_boy is currently broken at 2.9 and above. See: https://github.com/pytest-dev/pytest-factoryboy/issues/47 factory-boy<2.9.0 pytest-factoryboy recommonmark @@ -13,4 +14,4 @@ sphinx_rtd_theme tox mock django-debug-toolbar -packaging==16.8 \ No newline at end of file +packaging==16.8