Retry bad nonce errors with a new nonce #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realised that I don't need to do the clone of |
djc
reviewed
Sep 16, 2024
|
This is great, thanks! |
|
Sorry, I didn't realise you were actively reviewing and force pushed a change to use the |
|
No problem! |
djc
reviewed
Sep 17, 2024
src/lib.rs
Outdated
Comment on lines
517
to
521
| nonce = response | ||
| .parts | ||
| .headers | ||
| .get("Replay-Nonce") | ||
| .and_then(|v| v.to_str().map(|s| s.to_string()).ok()); |
There was a problem hiding this comment.
I think this is nonce_from_response()? Can we use that here?
Retry `urn:ietf:params:acme:error:badNonce` errors as they are defined as retryable[^1]. Requests failing with a bad nonce error will be retried three time retried three times before the failure is returned to the caller. This implenments the `BytesBody` trait for `bytes::Bytes` as we need to consume the response body to be able check if the failure was due to a bad nonce which required parsing the body. The body is only consumed if the response status is bad request, in all other cases the body is still lazily consumable. [^1]: https://datatracker.ietf.org/doc/html/rfc8555/#section-6.5
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm putting this up as a possible solution for handling bad nonce errors. The new
BytesBodyimplementation feels a bit weird but I couldn't think of a better way that wouldn't have wide reaching interface changes. I think it makes sense to do the retry withinClientso that everything benefits from it. The main thing this is missing is some backoff, though that may not even be necessary because we're not retrying due to a network or server side error.Fixes: #62