Update PDK to 1.18.1 and re-work tests #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is still a lot more to do here to get full coverage, and a lot of work to figure out testing across multiple OSes etc. however this is a solid start.
…urces which various defined types rely on
|
Awesome work, thanks! It's great when someone feeds back improvements. Don't worry about doing destructive work on the tests or preserving anything - I just ran a script which generated a skeleton set of tests, which never worked, and I never got further than that with testing. Unfortunately I changed jobs after that and I no longer use this module myself, so maintenance has really been limited to curating PRs that people such as yourself have kindly sent 🙂 Your PR looks great but I no longer have any means of testing it in a real environment, so I have eyeballed it and I'm happy to accept the PR. Look forward to seeing what other improvements are in the pipeline for your use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I'm reworking a puppet environment and as part of that we're throwing out our internal freeradius module and have elected to use this one. There are some changes required to get it to where we want it, so I'm contributing these changes back. This is the first of these.
Here I am updating PDK to 1.18.1. I had intended to test before and after, but found that the tests seemed to be broken and unmaintained. I've re-worked all the tests away from the generated tests so they can be maintained going forward. My focus has been to retain the original test cases (i.e., what was being tested) so have only added a few additional test cases and contexts. It is my intent to add more test cases and contexts however, if this PR is accepted, as part of other PRs I intend to send.