Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client attributes so that hashes and arrays work correctly #158

Merged
merged 1 commit into from
May 14, 2021

Conversation

nward
Copy link
Collaborator

@nward nward commented May 12, 2021

In d2885da I was changing if @var to if defined?(@var) and accidentally changed:

if @attributes.respond_to?('join')

to

if defined?(@attributes).respond_to?('join')

which obviously doesn't work.

This commit reverts that, and doesn't check check defined?(@attributes) several times.

@nward nward added this to the Version 4 milestone May 12, 2021
@nward nward requested a review from djjudas21 May 12, 2021 23:43
@nward nward merged commit 7a43a76 into djjudas21:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants