Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ubuntu 22.04 #186

Merged
merged 3 commits into from
Apr 26, 2023
Merged

add support for ubuntu 22.04 #186

merged 3 commits into from
Apr 26, 2023

Conversation

mxr0
Copy link
Contributor

@mxr0 mxr0 commented Mar 27, 2023

add version strings for Ubuntu 22.04 and ldap template for update parameter

@nward
Copy link
Collaborator

nward commented Apr 7, 2023

Hi @mxr0 - thanks for the contribution.

Keen to keep PRs limited to specific issues to keep things clear. I have created another PR to cover the LDAP config bug fix #190.

Can you remove the LDAP changes from your PR? You have allowed edits from maintainers but you have done this change on your main branch - I am not sure if you would auto-deploy this code or something like that, which might break your environment.

@mxr0
Copy link
Contributor Author

mxr0 commented Apr 7, 2023

Hi, thanks. I think i removed the LDAP fix from this PR. Please have a look if it this works for merging.

@mxr0
Copy link
Contributor Author

mxr0 commented Apr 26, 2023

Hi @nward what else is needed in order for this pull request to get merged to the main branch?

@nward nward merged commit 4200f25 into djjudas21:main Apr 26, 2023
@nward
Copy link
Collaborator

nward commented Apr 26, 2023

Hi @nward what else is needed in order for this pull request to get merged to the main branch?

I needed to push the other button :)

Sorry, I had it ready to go and got distracted the other day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants