From d7352eafe41505daa9db919b744d9715b576c9a4 Mon Sep 17 00:00:00 2001 From: Sebastian Wilzbach Date: Fri, 7 Jul 2017 05:15:15 +0200 Subject: [PATCH] Rename Fix to Auto-Close MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit People repeatedly have shown problems to recognize that a cross (✗) means that the PR won't be automatically closed (and shown) as part of the changelog. While this has been documented in #124, the best solution is to directly display the meaning on the Bot's comment. --- source/dlangbot/github.d | 2 +- test/comments.d | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/source/dlangbot/github.d b/source/dlangbot/github.d index dd4b8cc..1b68499 100644 --- a/source/dlangbot/github.d +++ b/source/dlangbot/github.d @@ -20,7 +20,7 @@ public import dlangbot.github_api; void printBugList(W)(W app, in IssueRef[] refs, in Issue[] descs) { auto combined = zip(refs.map!(r => r.id), refs.map!(r => r.fixed), descs.map!(d => d.desc)); - app.put("Fix | Bugzilla | Description\n"); + app.put("Auto-close | Bugzilla | Description\n"); app.put("--- | --- | ---\n"); foreach (num, closed, desc; combined) { diff --git a/test/comments.d b/test/comments.d index 10ba972..88953ea 100644 --- a/test/comments.d +++ b/test/comments.d @@ -17,7 +17,7 @@ unittest auto expectedComment = `### Bugzilla references -Fix | Bugzilla | Description +Auto-close | Bugzilla | Description --- | --- | --- ✗ | [8573](%s/show_bug.cgi?id=8573) | A simpler Phobos function that returns the index of the mix or max item `.format(bugzillaURL); @@ -47,7 +47,7 @@ unittest auto expectedComment = `### Bugzilla references -Fix | Bugzilla | Description +Auto-close | Bugzilla | Description --- | --- | --- ✗ | [8573](%s/show_bug.cgi?id=8573) | A simpler Phobos function that returns the index of the mix or max item `.format(bugzillaURL); @@ -79,7 +79,7 @@ unittest assert(req.method == HTTPMethod.PATCH); auto body_= req.json["body"].get!string; assert(body_.canFind("@andralex")); - assert(!body_.canFind("Fix | Bugzilla"), "Shouldn't contain bug header"); + assert(!body_.canFind("Auto-close | Bugzilla"), "Shouldn't contain bug header"); assert(!body_.canFind("/show_bug.cgi?id="), "Shouldn't contain a Bugzilla reference"); } ); @@ -107,7 +107,7 @@ unittest assert(req.method == HTTPMethod.PATCH); auto body_= req.json["body"].get!string; assert(body_.canFind("@andralex")); - assert(!body_.canFind("Fix | Bugzilla"), "Shouldn't contain bug header"); + assert(!body_.canFind("Auto-close | Bugzilla"), "Shouldn't contain bug header"); assert(!body_.canFind("/show_bug.cgi?id="), "Shouldn't contain a Bugzilla reference"); } ); @@ -240,7 +240,7 @@ unittest auto expectedComment = "### Bugzilla references -Fix | Bugzilla | Description +Auto-close | Bugzilla | Description --- | --- | --- ✗ | [8573](%s/show_bug.cgi?id=8573) | A simpler Phobos function that returns the index of the mix or max item