Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output-path, configs, builds to dub describe #2204

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

WebFreak001
Copy link
Member

@WebFreak001 WebFreak001 commented Dec 8, 2021

Also contains default-config and default-build

Extends the describe command from only being build options to also custom fields like this. Configs and builds was previously only exposed in "interactive" TUI, now as machine parsable format.

output-path is for building the full path including platform specific extensions for where a file is placed. This can be used to check for example after a build if a file has changed or do some extra work on it.

Needs tests right now

@WebFreak001 WebFreak001 marked this pull request as draft December 8, 2021 16:26
@WebFreak001
Copy link
Member Author

WebFreak001 commented Dec 10, 2021

found bugs:

  • when running with --build=unittest, the output-path is not the unittest executable

  • in arsd-official running dub describe :eventloop --config=library --data=output-path --data-list it segfaults (target type is sourceLibrary)

    using other data types it says Target 'arsd-official:eventloop' doesn't exist. Is the target type set to "none" in the package recipe?

note:

  • silently fails with exit code 2 if using a --config and the platform specifier does not match (was also earlier behavior) - makes sense because on different platforms the configurations may result in different specifications - and exiting with failure is a good way to say invalid config for this platform. There should be some output to stderr though.

Also contains default-config and default-build

Extends the describe command from only being build options to also
custom fields like this. Configs and builds was previously only exposed
in "interactive" TUI, now as machine parsable format.

output-path is for building the full path including platform specific
extensions for where a file is placed. This can be used to check for
example after a build if a file has changed or do some extra work on it.
WebFreak001 added a commit to WebFreak001/dub that referenced this pull request Sep 4, 2023
supersedes the trivial part of dlang#2204
WebFreak001 added a commit to WebFreak001/dub that referenced this pull request Sep 4, 2023
supersedes the trivial part of dlang#2204
WebFreak001 added a commit that referenced this pull request Sep 5, 2023
supersedes the trivial part of #2204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant