Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add betterC support - fixes #1636 #2581

Merged
merged 4 commits into from
Feb 9, 2023
Merged

Add betterC support - fixes #1636 #2581

merged 4 commits into from
Feb 9, 2023

Conversation

etcimon
Copy link
Contributor

@etcimon etcimon commented Feb 8, 2023

This commit results in the dub test command being executed correctly when using the -betterC dflag.

}
}
};
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add EOL before EOF

@WebFreak001
Copy link
Member

WebFreak001 commented Feb 9, 2023

in the future please don't work on master, it makes it harder to collaborate on the PRs as well as complicates making multiple PRs in parallel. Instead create a branch for each PR you want to make.

Also: welcome back to D ^^

Copy link
Member

@WebFreak001 WebFreak001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good solution, I also added a test

@WebFreak001
Copy link
Member

test failure is on master on windows because of long path names, so I'll ignore it

@WebFreak001 WebFreak001 merged commit 89f9b8e into dlang:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants