-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --deep flag to dub build
#2647
Conversation
✅ PR OK, no changes in deprecations or warnings Total deprecations: 14 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5272064 bin/dub
rough build time=90s Full build output
|
Allows to build all dependencies of a static library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rtbo So far, the only thing I see missing is a test. Add a test using the --deep flag
I'm also really looking for that since I have been using quite a hack for my engine
make it clear what part of the code is used for recursive build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @WebFreak001 @Geod24
@rtbo I have wrote this file here: Added By specifying this flag, you can now build all the dependencies
If a staticLibrary A depends on staticLibrary B, and the --deep Feel free to modify as you see fit. This is a required file which goes inside the changelog folder. |
Hey there @WebFreak001 @Geod24 can you take a look into this PR? |
Allows to build all dependencies of a static library.
This provides the same functionality as the dub-build-deep package.
The difference is that all dependencies are built in the same DUB invocation, which imply that the build will be fully compatible with
dub describe
.E.g.
dub describe vibe-d:http
will describe the build settings of all dependencies ofvibe-d:http
anddub build --deep vibe-d:http
will build all dependencies with the exact same build settings.If we build dependencies one by one (as done by
dub-build-deep
), some settings will differ.See also #2644
Fixes #2224 (and possibly #2209)