-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce PackageName, to fully type a package name #2801
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
-executable size=5228376 bin/dub
-rough build time=61s
+executable size=5277720 bin/dub
+rough build time=62s Full build output
|
Package names being passed around in the Dub codebase are string, which is problematic as it suffers from validation / semantic issues. Validation because we cannot impose restrictions on characters or length easily, and semantic because some functions expect a main package while some would accept a subpackage. Introducing a type will remedy both those issues.
Geod24
force-pushed
the
mlang/PackageName
branch
from
January 15, 2024 15:39
1e1bd74
to
8744904
Compare
PetarKirov
approved these changes
Jan 15, 2024
Not that I can think of. I started to adapt the APIs locally, mostly for the benefit of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this just replaces use of the two functions that deal with package names as string. Deprecating / replacing the API is another undertaking that I felt was best done separately.