-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve unittest framework to have a virtual FS #2820
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
-executable size=5339480 bin/dub
-rough build time=62s
+executable size=5339488 bin/dub
+rough build time=61s Full build output
|
Geod24
force-pushed
the
mlang/FSTests
branch
2 times, most recently
from
January 19, 2024 18:28
43a7c6d
to
82aa7ee
Compare
There's a mismatch between what our vibecompat |
This gets the unittest framework closer to the actual behavior, and allows us to mock basic FS operations such as mkdir and writeFile. Further improvements can be made to support more operations, and to have package setup done before `TestDub` instantiation.
I used a different approach since #2821 introduces its own set of issues. |
thewilsonator
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets the unittest framework closer to the actual behavior, and allows us to mock basic FS operations such as mkdir and writeFile. Further improvements can be made to support more operations, and to have package setup done before
TestDub
instantiation.